Repository navigation
fix(ci): run idris2 --check from the proof's own directory (Idris2 Proof gate is red on main) - #47
Merged
Conversation
The Idris2 Proof gate added in #46 went red on main: Idris2 derives the expected module name from the path it is given, so checking `a-sounder-constitution/formal/Constitution.idr` from the repo root made it expect a module named `a-sounder-constitution.formal.Constitution` (impossible — hyphens aren't legal in module names), not `module Constitution`: Error: Module name Constitution does not match file name "a-sounder-constitution/formal/Constitution.idr" The build/install steps were fine; only the check invocation was wrong. Run it with `working-directory: a-sounder-constitution/formal` and `idris2 --check Constitution.idr`, matching how it is verified locally. Reproduced and fixed locally with Idris2 0.7.0: full path -> exit 1 (same error); from the formal/ dir -> exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015w8C1xaGwiDcHHjfuxHBd6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate from #46 is failing on
mainThe
Idris2 Proofworkflow added in #46 went red onmain(run #2). The build and install of Idris2 0.7.0 succeeded; the failure is the check invocation:Why
Idris2 derives the expected module name from the path you give it. Checking
a-sounder-constitution/formal/Constitution.idrfrom the repo root makes it expectmodule a-sounder-constitution.formal.Constitution— which can't even be a legal module name (hyphens). The file declaresmodule Constitution, which is correct. I verified the proof locally by running from insideformal/(idris2 --check Constitution.idr); the workflow ran it from the repo root, so it only surfaced once CI actually executed — and #46 merged before its first run finished.Fix
Run the check from the module's own directory:
Verified locally (Idris2 0.7.0)
working-directory: a-sounder-constitution/formal+idris2 --check Constitution.idr→ exit 0, cleanpermissions/ SHA-pins)This PR edits the workflow file, so it matches the path filter and the gate runs on this PR — CI here is the end-to-end proof of the fix. Worth letting
idris2-checkgo green before merging this time.🤖 Generated with Claude Code
https://claude.ai/code/session_015w8C1xaGwiDcHHjfuxHBd6
Generated by Claude Code