Skip to content

docs: correct Signed commits section (squash does not sign bot commits) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Sep 30, 2026
Merged

docs: correct Signed commits section (squash does not sign bot commits) #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ We follow [Conventional Commits](https://www.conventionalcommits.org/):
[optional footer]
```

## Signed Commits
## Signed commits

Every commit that reaches the default branch must be signed; a ruleset refuses
unsigned pushes. Estate policy:
Expand All @@ -97,7 +97,9 @@ unsigned pushes. Estate policy:
as a *signing* key (`gpg.format=ssh`, `commit.gpgsign=true`). The committer
email must be verified on that account.
- **Apps, bots and workflows** never `git push` local commits. They write
through the API (`createCommitOnBranch`, the estate `signed-push` action, or a
squash merge) so that GitHub signs the commit.
- Merge PRs with **squash**. Rebase-merge replays commits unsigned and is
disabled.
through the API (`createCommitOnBranch` or the estate `signed-push` action)
so that GitHub signs each commit.
- Merge PRs with **squash**. The ruleset checks every commit on the PR branch,
not just the result, so one unsigned commit blocks the merge. Re-create such a
branch with signed commits (`git cherry-pick -S`) and open a new PR.
Rebase-merge replays commits unsigned and is disabled.
Loading