Repository navigation
fix(claude): exact check-script rules instead of a mid-command wildcard - #95
Merged
Merged
Conversation
…script rules Claude Code warns at startup that a * before the end of a Bash rule is a permission wildcard that also matches any options inserted there. List the four scripts/check-*.sh scripts explicitly. File written in JCS canonical form (ijson-jcs fix), per D306. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GpUzjdhWFi26k6s7AWxYcf
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Replaces the Claude Code allow rule
Bash(bash scripts/check-*.sh:*)with four exact rules. Claude Code 2.1.285 warns at startup that a*before the end of a Bash rule is a permission wildcard, so it also approves any options inserted at that position without a prompt. The*here was meant as a filename glob.Changes
.claude/settings.json: the wildcard rule becomes one rule per existing script:check-no-md-in-docs.sh,check-no-project-identifiers.sh,check-root-shape.sh,check-state.sh. Every other rule and the SessionStart hook are unchanged.ijson-jcs fix(estate JSON standard D306). That is why the diff shows a 1-line file.📌 New pins
Head SHA:
739b35b6853652bf5efcee52ecaa2efca703f54d. No action, lockfile or container pins are added or changed.RSR Quality Checklist
Required
.claude/settings.jsonijson-jcs check .claude/settings.json→OKunsafeblocks without// SAFETY:comments: no code changed.envfiles includedAs Applicable
TOPOLOGY.md: not applicableTesting
ijson-jcs check .claude/settings.json(hyperpolymath/ijson-jcs CLI at0fdeea7) →OK, rc 0. The checker was first shown to reject a duplicate-key file and flag a non-canonical one.*in aBash(...)rule other than a trailing*or:*) → 0 of 16 rules flagged.git ls-tree origin/main scripts/lists exactly the fourcheck-*.shscripts now named.Screenshots
Not applicable.
Deferred red checks
These checks are not required, and all were already failing on
mainat438d2b1c39before this PR:Validate DEED manifests,Validate K9 contracts,governance / Actions lockfile verify,governance / Check Workflow Stalenessandgovernance / Workflow security linter. Deferred to #96.🤖 Generated with Claude Code
https://claude.ai/code/session_01GpUzjdhWFi26k6s7AWxYcf