Repository navigation
ci(secret-scan): canonical estate scanner caller, key scan (D243) #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2531e52
ci(secret-scan): canonical estate scanner caller, key scan (D243)
hyperpolymath cadaac3
ci(secret-scan): drop secrets: inherit from the scanner caller (least…
hyperpolymath cba607f
Merge branch 'main' into ci/secret-scan-floor-caller
hyperpolymath 1f5afa8
docs(algorithm-shield): clarify the array bounds guarantee in the arc…
coderabbitai[bot] ad4b082
Merge branch 'main' into ci/secret-scan-floor-caller
hyperpolymath d9282fd
Merge branch 'main' into ci/secret-scan-floor-caller
hyperpolymath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,83 +1,27 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # Prevention workflow - scans for hardcoded secrets before they reach main | ||
| # Prevention workflow - scans for hardcoded secrets before they reach main. | ||
| # | ||
| # Calls the estate's shared secret scanner (gitleaks + rust-secrets + | ||
| # shell-secrets). The job key MUST stay `scan`: the estate-wide | ||
| # Secret-Scan-Floor ruleset requires the check context `scan / gitleaks`. | ||
| # | ||
| # No `secrets:` line, deliberately: the reusable references no secrets | ||
| # (gitleaks runs as a checksum-verified binary, not gitleaks-action), so | ||
| # `secrets: inherit` would only hand it every repo and org secret (CWE-250). | ||
| name: Secret Scanner | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| # Estate guardrail: cancel superseded runs so re-pushes / rebased PR | ||
| # updates do not pile up queued runs against the shared account-wide | ||
| # Actions concurrency pool. Applied only to read-only check workflows | ||
| # (no publish/mutation), so cancelling a superseded run is always safe. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| actions: read | ||
| contents: read | ||
|
|
||
| jobs: | ||
| trufflehog: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4 | ||
| with: | ||
| fetch-depth: 0 # Full history for scanning | ||
|
|
||
| - name: TruffleHog Secret Scan | ||
| uses: trufflesecurity/trufflehog@6c05c4a00b91aa542267d8e32a8254774799d68d # v3 | ||
| with: | ||
| # The v3 action injects --fail automatically on pull_request events. | ||
| # Passing --fail here triggers "flag 'fail' cannot be repeated". | ||
| extra_args: --only-verified | ||
|
|
||
| gitleaks: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Gitleaks Secret Scan | ||
| uses: gitleaks/gitleaks-action@ff98106e4c7b2bc287b24eaf42907196329070c7 # v2 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # Rust-specific: Check for hardcoded crypto values | ||
| rust-secrets: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4 | ||
|
|
||
| - name: Check for hardcoded secrets in Rust | ||
| run: | | ||
| if ! find . -name Cargo.toml -not -path './target/*' -print -quit | grep -q .; then | ||
| echo 'No Cargo.toml found — skipping Rust secrets check' | ||
| exit 0 | ||
| fi | ||
| # Patterns that suggest hardcoded secrets | ||
| PATTERNS=( | ||
| 'const.*SECRET.*=.*"' | ||
| 'const.*KEY.*=.*"[a-zA-Z0-9]{16,}"' | ||
| 'const.*TOKEN.*=.*"' | ||
| 'let.*api_key.*=.*"' | ||
| 'HMAC.*"[a-fA-F0-9]{32,}"' | ||
| 'password.*=.*"[^"]+"' | ||
| ) | ||
|
|
||
| found=0 | ||
| for pattern in "${PATTERNS[@]}"; do | ||
| if grep -rn --include="*.rs" -E "$pattern" src/; then | ||
| echo "WARNING: Potential hardcoded secret found matching: $pattern" | ||
| found=1 | ||
| fi | ||
| done | ||
|
|
||
| if [ $found -eq 1 ]; then | ||
| echo "::error::Potential hardcoded secrets detected. Use environment variables instead." | ||
| exit 1 | ||
| fi | ||
| scan: | ||
| uses: hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@74d2f66f575246cf6e313ae7775f44df6e097ff2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🛡️ Detected with Advanced Tier | 🟠 Major | 🏗️ Heavy lift
Sensitive Data Exposure
Reachability: External
Exploitability: Trivial
CWE: CWE-532 — Insertion of Sensitive Information into Log File
Use a reusable scanner that redacts shell findings.
The
shell-secretsjob copies each matching source line intocontentand emits it throughecho "::warning::$filepath:$lineno: $content". A non-exempt hardcoded credential can therefore enter the log and annotation. The separategitleaksjob’s--redactoption does not protect this output.Update the shared scanner to report only the path, line, and rule. Then update this pin.
View in Security blast radius
🤖 Prompt for AI Agents
Source: Learnings