Repository navigation
docs: add Signed commits section to CONTRIBUTING - #89
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
|
| Layer / File(s) | Summary |
|---|---|
Signing requirements and merge procedures .github/CONTRIBUTING.md |
The guide requires signed commits and describes SSH signing for people and interactive agents, API-based commits for apps, bots and workflows, and squash merging. It also states that unsigned commits must be recreated as signed commits and that rebase-merge is disabled. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to de1c8
The guide accurately explains the signing requirement and squash-merge procedure, so no material merge risk remains.
Architecture Summary
Architecture risk: 🔵 Low · up to de1c8
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
- observed — Modified behavior in .github/CONTRIBUTING.md: Adds commit-signing requirements and procedures: people and interactive agents use a registered GitHub SSH signing key and verified committer email; apps, bots and workflows write commits through the API rather than pushing locally; PRs use squash merges, and unsigned commits must be recreated as signed commits. Rebase-merge is stated to be disabled.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the change and its rationale, but it omits the required RSR Quality Checklist and dedicated Testing and Screenshots sections from the repository template. It also does not doc… | Update the description to follow the repository template. Add the RSR Quality Checklist, mark each applicable item, add a Testing section with test results or explain why testing is not applicable, and add a Screenshots section or mark it n… |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely identifies the main change: adding a Signed commits section to CONTRIBUTING. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Description check
Explanation
The description explains the change and its rationale, but it omits the required RSR Quality Checklist and dedicated Testing and Screenshots sections from the repository template. It also does not document the required checks or mark non-applicable items.
Resolution
Update the description to follow the repository template. Add the RSR Quality Checklist, mark each applicable item, add a Testing section with test results or explain why testing is not applicable, and add a Screenshots section or mark it not applicable.
- ❌ Autofix failed (check again to retry)
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit signs a commit with care,
Then checks the key is registered there.
API commits hop along,
Squash merges bring the branch home strong.
No unsigned hops reach the default tree,
The rabbit thumps: signed commits for me!
Comment @coderabbitai help to get the list of available commands.
|
Autopilot could not be updated. Open Coding to check access and billing. |
|
The CI failures may require manual intervention. View agent analysis |
|
The agent ran but didn't make any changes. The issues may already be fixed or require manual intervention. |
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f