Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #110

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b14617f0-aba3-4635-ab0f-c81996a3dbde

📥 Commits

Reviewing files that changed from the base of the PR and between 6e700a0 and 9e31dbc.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (33)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: scan / rust-secrets
  • GitHub Check: Runtime Policy
  • GitHub Check: openssf-compliance
  • GitHub Check: check
  • GitHub Check: analyze (actions, none)
  • GitHub Check: check
  • GitHub Check: estate-rules
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: panic-attack assail
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: Validate K9 contracts
  • GitHub Check: lint-workflows
  • GitHub Check: Groove manifest check
  • GitHub Check: lint-workflows
🔇 Additional comments (2)
.github/workflows/governance.yml (1)

21-24: LGTM!

.github/workflows/mirror.yml (1)

17-20: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated workflow permission declarations to ensure governance and mirroring jobs retain the required read and security-event access.
    • No user-facing functionality or capabilities have changed.

Walkthrough

The governance and mirror workflows now declare their existing permissions at the job level. The permission values remain unchanged.

Changes

Workflow permission scope

Layer / File(s) Summary
Job-level permission declarations
.github/workflows/governance.yml, .github/workflows/mirror.yml
Both jobs declare actions: read, contents: read, and security-events: write directly at job level.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the YAML indentation problem and the intended fix, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and … Rewrite the description using the repository template. Include the Summary and Changes sections, complete the RSR Quality Checklist, describe the validation performed under Testing, and add Screenshots or state that they are not applicable …
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: repairing the invalid YAML permissions block indentation in CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the YAML indentation problem and the intended fix, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections.

Resolution

Rewrite the description using the repository template. Include the Summary and Changes sections, complete the RSR Quality Checklist, describe the validation performed under Testing, and add Screenshots or state that they are not applicable under Screenshots.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions sit at job level, straight
Actions and contents can be read
Security events can now be fed
The YAML paths are clear and neat

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 1ca735d into main Sep 21, 2026
33 of 37 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant