Repository navigation
fix(ci): re-pin rust-ci-reusable past toolchain-input breakage - #45
Merged
Merged
Conversation
Re-pins rust-ci-reusable.yml from d135b05bfc647d0c0fbfedc7e80f37ea50f49236 (pre-fix) to 412a7031577112b31ee287cc6060179d638d6500 (standards main). The old SHA predates standards#439, which added the mandatory `toolchain: stable` input to the SHA-pinned dtolnay/rust-toolchain step. Without it, all four rust-ci jobs fail fast with `'toolchain' is a required input`. This restores Rust CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
hyperpolymath
enabled auto-merge (squash)
July 3, 2026 22:31
hyperpolymath
added a commit
that referenced
this pull request
Oct 14, 2026
#107) ## What was failing `rust-ci / Cargo check + clippy + fmt` is red on every run, `main` included. Its most recent failure was on #106. The job dies in its first real step: ``` Run : parse toolchain version 'toolchain' is a required input ##[error]Process completed with exit code 1. ``` `rust-ci.yml` pins `hyperpolymath/standards` at `d135b05b`. At that commit, `rust-ci-reusable.yml` calls `dtolnay/rust-toolchain` by commit SHA and passes no `toolchain:` input. That action reads the toolchain from its `@`-ref (`@stable`). A SHA ref carries no version, so the step fails before any cargo command runs. ## Why it came back #45 already moved this pin past the breakage, to `412a7031`. Then the 18 Aug merge of `ci/fix-ossf-scorecard-startup` (`197735c`) resolved the pin back to `d135b05b`, and the check has been red since. ## The fix Re-pin to `standards@95de3dfc` (current `main`). Its `rust-ci-reusable.yml` passes `toolchain: stable` in all four jobs. That commit is safe to pin to. The standards `scripts/lock-selfcheck.sh` warns that a newer standards commit can be *less* usable when Dependabot bumps an action without regenerating `actions.lock`. So I checked by hand: every action ref `rust-ci-reusable.yml` names at `95de3dfc` is keyed in that commit's `actions.lock`, under both `workflows:` and `dependencies:`: - `actions/checkout@3d3c42e5` - `dtolnay/rust-toolchain@e2a55d2f` - `goto-bus-stop/setup-zig@abea47f8` - `swatinem/rust-cache@6323deb1` ## Verified locally The reusable's own commands, run on Rust 1.97 and on 1.99 (current stable, which CI installs). All pass: - `cargo check --locked --all-targets` - `cargo fmt --all -- --check` - `cargo clippy --locked --all-targets -- -D warnings` - `cargo test --locked --all-targets` So once the toolchain installs, the job should go green, not trade one red for another. ## Not in this PR - **Codeac analyze results** stays `pending` on #106. It is a commit status from the external Codeac service, not a workflow in this repo, and it is not a required check. The only required check on `main` is `scan / gitleaks`. Standards ruling D258 ("Codeac OAuth → reinstall it as an App") is an owner action outside the repo. - #106 keeps its red `rust-ci` until it gets a new CI event after this merges, e.g. `·@·d·ependabot r·ebase`. Fixes #105 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye --- _Generated by [Claude Code](https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins
rust-ci-reusable.ymlfromd135b05bfc647d0c0fbfedc7e80f37ea50f49236(pre-fix) to412a7031577112b31ee287cc6060179d638d6500(standards main).Why: the old SHA predates standards#439. Under a SHA-pinned
dtolnay/rust-toolchain, thetoolchaininput is mandatory; without it all four rust-ci jobs (check/test/audit/coverage) fail immediately with'toolchain' is a required input— an estate-wide Rust CI breakage. This PR restores green here.🤖 Generated with Claude Code