Repository navigation
fix(ci): restore green build — printpdf 0.9 migration, clippy fix, lockfile drift - #128
Merged
Merged
Conversation
…le drift Follow-up to #127 (which resolved #122): the first real CI compile of the merged FFP stack surfaced three blocking problems. 1. presswerk-document failed to compile: writer.rs still used the printpdf 0.8 ops `SetFontSizeBuiltinFont` / `WriteTextBuiltinFont`, removed upstream when printpdf was bumped to 0.9.1 (#20, May 2026). The breakage was latent for months because presswerk-core failed to compile first; fixing core in #125/#127 unmasked it. Migrate to the 1:1 PDF operators `Op::SetFont` (Tf) / `Op::ShowText` (Tj) with `PdfFontHandle::Builtin`, the replacement documented in printpdf 0.9. 2. clippy `manual_map` (deny-warnings) in the FFP legacy→v1 bridge in presswerk-core/src/provenance.rs — rewrite the `else if let Some(p) = &legacy.producer { Some(...) } else { None }` chain as `legacy.producer.as_ref().map(...)` per clippy's suggestion. Preserves the E0382 fix (borrow + clone, no moves). 3. CI plumbing: - rust-ci.yml: drop the fmt job added by #126 and restore the wrapper-only form; its non-empty actions.lock section caused startup_failure (0 jobs) on every run since. Auto-formatting stays covered by the standalone fmt.yml workflow, which works. - actions.lock: reconcile drifted pins so workflow refs and the lockfile agree — swatinem/rust-cache canonical lowercase key in fmt.yml; github/codeql-action v4.38.0 → v4.38.2 (workflow was bumped by dependabot in #121 without a relock, killing CodeQL at startup); haskell-actions/setup v2.12.0 → v2.12.1 (casket-pages drift). rust-ci.yml section restored to [] per estate convention for reusable-call wrappers (cf. governance.yml). Note: the Governance "Actions lockfile verify" failure predates this work (failing on every main push since mid-September); this fixes the drifts that are identifiable without the gh-actions-lock tool. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
force-pushed
the
arena/01a108e5-presswerk
branch
from
October 4, 2026 22:34
470235f to
b7394b1
Compare
CI (b5d21ca) advanced past presswerk-document and surfaced the next blocking layer; this fixes it. - presswerk-security/audit.rs `AuditLog::count`: rusqlite 0.39 has no `FromSql` impl for `u64` (SQLite integers are signed i64), so `row.get(0)` into `Result<u64,_>` failed E0277. Read as `i64` and widen to `u64` (COUNT(*) is never negative). - presswerk-document/provenance.rs: two clippy `collapsible_if` sites (deny-warnings) in the FFP detector — collapse nested `if let` chains into edition-2024 let-chains (`if let Ok(catalog) && let Ok(meta_obj)`, and the /Ch array-walk triple `if let ... && let ... && is_meaningful`). Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
hyperpolymath
force-pushed
the
arena/01a108e5-presswerk
branch
from
October 4, 2026 22:36
7f233c9 to
a0d952e
Compare
|
Autopilot could not be updated. Open Coding to check access and billing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #127 (resolves #122). The first full CI compile of the merged FFP stack surfaced three blockers; this fixes all of them.
1.
presswerk-documentcompile failure (E0599) — pre-existing, unmaskedwriter.rsstill used printpdf 0.8 opsOp::SetFontSizeBuiltinFont/Op::WriteTextBuiltinFont, which upstream removed when printpdf was bumped to 0.9.1 back in #20 (May 2026). The breakage stayed latent becausepresswerk-corefailed to compile first; repairing core in #125/#127 unmasked it. Migrated to the 1:1 PDF operators documented as their replacement in printpdf 0.9:Op::SetFont { font: PdfFontHandle::Builtin(BuiltinFont::Helvetica), size }(Tf)Op::ShowText { items }(Tj/TJ)2. clippy
manual_mapin the FFP legacy→v1 bridgepresswerk-core/src/provenance.rs—else if let Some(p) = &legacy.producer { Some(…) } else { None }rewritten aslegacy.producer.as_ref().map(…)per clippy's own suggestion. The E0382 repair is preserved (borrow + clone, no moves).3. CI plumbing
fmtjob added by fix: correct provenance moved-value and get_array_ids syntax + fmt auto-fix #126 and restored the wrapper-only form — its non-emptyactions.locksection causedstartup_failure(0 jobs) on every run since the merge. Auto-formatting remains covered by the standalonefmt.ymlworkflow (proven: it pushed the fmt commit on fix(ffp): unconflict #126 onto main and repair the errors hiding behind its syntax fix (#122) #127).fmt.yml: canonical lowercaseswatinem/rust-cache@v2.9.2key (matchesdependencies:+ all other sections)github/codeql-actionv4.38.0 → v4.38.2 (workflow bumped by dependabot in chore(deps): bump github/codeql-action from 4.38.1 to 4.38.2 in the actions group #121 without a relock — CodeQL has beenstartup_failuresince)haskell-actions/setupv2.12.0 → v2.12.1 (casket-pages drift)rust-ci.ymlsection restored to[](estate convention for reusable-call wrappers, cf.governance.yml)No Rust toolchain is reachable from this workspace, so verification is by careful API audit against printpdf v0.9 sources plus CI on this PR.