Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #97

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 25cca2b5-9923-47a5-9ade-293a5c676686

📥 Commits

Reviewing files that changed from the base of the PR and between ec03077 and 0e77a51.

📒 Files selected for processing (1)
  • .github/workflows/governance.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (23)
  • GitHub Check: build
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: Analyze (actions)
  • GitHub Check: lint-workflows
  • GitHub Check: build
  • GitHub Check: lint-workflows
🔇 Additional comments (1)
.github/workflows/governance.yml (1)

36-39: LGTM!


📝 Summary

Summary by CodeRabbit

  • Security
    • Updated workflow permissions to use read-only access for Actions and repository contents, while allowing security-event updates.

Walkthrough

The reusable governance workflow now declares its Actions, contents, and security-events permissions at job level.

Changes

Governance workflow permissions

Layer / File(s) Summary
Job-level permission declarations
.github/workflows/governance.yml
The job declares actions: read, contents: read, and security-events: write permissions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: metadatastician

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: correcting invalid YAML permissions block indentation in CI.
Description check ✅ Passed The description directly explains the invalid YAML, the indentation correction, preserved permissions, and validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

I hop past the workflow gate
Read-only paths now sit in state
Security events may write
The governance scope is tight
A tidy change, just right

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit fca60e9 into main Sep 21, 2026
20 of 25 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant