Skip to content

ci(hypatia): standardise the wrapper caller id to the canonical `hypa… - #101

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/hypatia-caller-id
Oct 1, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/hypatia-caller-id

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

…tia`

The check a reusable-caller job publishes is <caller job id> / <inner job display name>. The estate's canonical required context is hypatia / Hypatia Neurosymbolic Analysis, so the caller job must be named hypatia. This wrapper named it scan and so published scan / Hypatia Neurosymbolic Analysis — two names for one gate, and any requirement written against one is unsatisfiable in a repository that publishes the other (the defect class of hyperpolymath/tropical-types#17).

Rename only: the job body, its pin, inputs and secrets are byte-for-byte unchanged. Audit-first, requirement-aware sweep —
hyperpolymath/standards scripts/propagate-hypatia-caller-id.sh.

Summary

Changes

RSR Quality Checklist

Required

  • Tests pass (just test or equivalent)
  • Code is formatted (just fmt or equivalent)
  • Linter is clean (no new warnings or errors)
  • No banned language patterns (no TypeScript, no npm/bun, no Go/Python)
  • No unsafe blocks without // SAFETY: comments
  • No banned functions (believe_me, unsafeCoerce, Obj.magic, Admitted, sorry)
  • SPDX license headers present on all new/modified source files
  • No secrets, credentials, or .env files included

As Applicable

  • .machine_readable/descriptiles/STATE.a2ml updated (if project state changed)
  • .machine_readable/descriptiles/ECOSYSTEM.a2ml updated (if integrations changed)
  • .machine_readable/descriptiles/META.a2ml updated (if architectural decisions changed)
  • Documentation updated for user-facing changes
  • TOPOLOGY.md updated (if architecture changed)
  • CHANGELOG or release notes updated
  • New dependencies reviewed for license compatibility (MPL-2.0 / MPL-2.0)
  • ABI/FFI changes validated (src/interface/abi/ and src/interface/ffi/ consistent)

Testing

Screenshots

…tia`

The check a reusable-caller job publishes is `<caller job id> / <inner job
display name>`. The estate's canonical required context is
`hypatia / Hypatia Neurosymbolic Analysis`, so the caller job must be named
`hypatia`. This wrapper named it `scan` and so published
`scan / Hypatia Neurosymbolic Analysis` — two names for one gate, and any
requirement written against one is unsatisfiable in a repository that
publishes the other (the defect class of hyperpolymath/tropical-types#17).

Rename only: the job body, its pin, inputs and secrets are byte-for-byte
unchanged. Audit-first, requirement-aware sweep —
hyperpolymath/standards scripts/propagate-hypatia-caller-id.sh.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 433805cc-836f-47c5-85f5-9586cde879f2

📥 Commits

Reviewing files that changed from the base of the PR and between aa46c9a and c06d025.

📒 Files selected for processing (1)
  • .github/workflows/hypatia-scan.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (12)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: rust-ci / Cargo audit (security)
  • GitHub Check: rust-ci / Cargo check + clippy + fmt
  • GitHub Check: rust-ci / llvm-cov line coverage
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Build Ddraig Pages artifact
  • GitHub Check: Burrower proof safety
  • GitHub Check: semgrep-cloud-platform/scan
⚠️ CI failures not shown inline (5)

GitHub Actions: Rust CI / 4_rust-ci _ Detect Cargo.toml.txt: ci(hypatia): standardise the wrapper caller id to the canonical hypatia

Conclusion: failure

View job details

##[group]Fetching the repository
 [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/pull/94/merge:refs/remotes/pull/94/merge
 ##[error]fatal: couldn't find remote ref refs/pull/94/merge

GitHub Actions: Workflow Security Linter / 0_lint-workflows.txt: ci(hypatia): standardise the wrapper caller id to the canonical `hypa…

Conclusion: failure

View job details

##[group]Run echo "=== Checking SPDX License Headers ==="
 �[36;1mecho "=== Checking SPDX License Headers ==="�[0m
 �[36;1mfailed=0�[0m
 �[36;1mfor file in .github/workflows/*.yml .github/workflows/*.yaml; do�[0m
 �[36;1m  [ -f "$file" ] || continue�[0m
 �[36;1m  if ! head -1 "$file" | grep -q "^# SPDX-License-Identifier:"; then�[0m
 �[36;1m    echo "ERROR: $file missing SPDX header"�[0m
 �[36;1m    failed=1�[0m
 �[36;1m  fi�[0m
 �[36;1mdone�[0m
 �[36;1mif [ $failed -eq 1 ]; then�[0m
 �[36;1m  echo "Add '# SPDX-License-Identifier: MPL-2.0' as first line"�[0m
 �[36;1m  exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "All workflows have SPDX headers"�[0m
 shell: /usr/bin/bash -e {0}
 ##[endgroup]
 === Checking SPDX License Headers ===
 ERROR: .github/workflows/boj-build.yml missing SPDX header
 ERROR: .github/workflows/codeql.yml missing SPDX header
 ERROR: .github/workflows/dependabot-automerge.yml missing SPDX header
 ERROR: .github/workflows/dogfood-gate.yml missing SPDX header
 ERROR: .github/workflows/governance.yml missing SPDX header
 ERROR: .github/workflows/guix-nix-policy.yml missing SPDX header
 ERROR: .github/workflows/hypatia-scan.yml missing SPDX header
 ERROR: .github/workflows/instant-sync.yml missing SPDX header
 ERROR: .github/workflows/label-triage.yml missing SPDX header
 ERROR: .github/workflows/labels.yml missing SPDX header
 ERROR: .github/workflows/main-estate-audit.yml missing SPDX header
 ERROR: .github/workflows/mirror.yml missing SPDX header
 ERROR: .github/workflows/openssf-compliance.yml missing SPDX header
 ERROR: .github/workflows/pages.yml missing SPDX header
 ERROR: .github/workflows/proof-safety.yml missing SPDX header
 ERROR: .github/workflows/push-email-notify.yml missing SPDX header
 ERROR: .github/workflows/quality.yml missing SPDX header
 ERROR: .github/workflows/release.yml missing SPDX header
 ERROR: .github/workflows/rhodibot.yml missing SPDX header
 ERROR: .github/workflows/runtime-policy.yml missing SPDX header
 ERROR: .github/wo...

GitHub Actions: Workflow Security Linter / lint-workflows: ci(hypatia): standardise the wrapper caller id to the canonical `hypa…

Conclusion: failure

View job details

##[group]Run echo "=== Checking SPDX License Headers ==="
 �[36;1mecho "=== Checking SPDX License Headers ==="�[0m
 �[36;1mfailed=0�[0m
 �[36;1mfor file in .github/workflows/*.yml .github/workflows/*.yaml; do�[0m
 �[36;1m  [ -f "$file" ] || continue�[0m
 �[36;1m  if ! head -1 "$file" | grep -q "^# SPDX-License-Identifier:"; then�[0m
 �[36;1m    echo "ERROR: $file missing SPDX header"�[0m
 �[36;1m    failed=1�[0m
 �[36;1m  fi�[0m
 �[36;1mdone�[0m
 �[36;1mif [ $failed -eq 1 ]; then�[0m
 �[36;1m  echo "Add '# SPDX-License-Identifier: MPL-2.0' as first line"�[0m
 �[36;1m  exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "All workflows have SPDX headers"�[0m
 shell: /usr/bin/bash -e {0}
 ##[endgroup]
 === Checking SPDX License Headers ===
 ERROR: .github/workflows/boj-build.yml missing SPDX header
 ERROR: .github/workflows/codeql.yml missing SPDX header
 ERROR: .github/workflows/dependabot-automerge.yml missing SPDX header
 ERROR: .github/workflows/dogfood-gate.yml missing SPDX header
 ERROR: .github/workflows/governance.yml missing SPDX header
 ERROR: .github/workflows/guix-nix-policy.yml missing SPDX header
 ERROR: .github/workflows/hypatia-scan.yml missing SPDX header
 ERROR: .github/workflows/instant-sync.yml missing SPDX header
 ERROR: .github/workflows/label-triage.yml missing SPDX header
 ERROR: .github/workflows/labels.yml missing SPDX header
 ERROR: .github/workflows/main-estate-audit.yml missing SPDX header
 ERROR: .github/workflows/mirror.yml missing SPDX header
 ERROR: .github/workflows/openssf-compliance.yml missing SPDX header
 ERROR: .github/workflows/pages.yml missing SPDX header
 ERROR: .github/workflows/proof-safety.yml missing SPDX header
 ERROR: .github/workflows/push-email-notify.yml missing SPDX header
 ERROR: .github/workflows/quality.yml missing SPDX header
 ERROR: .github/workflows/release.yml missing SPDX header
 ERROR: .github/workflows/rhodibot.yml missing SPDX header
 ERROR: .github/workflows/runtime-policy.yml missing SPDX header
 ERROR: .github/wo...

GitHub Actions: Hypatia Security Scan / 0_hypatia _ Hypatia Neurosymbolic Analysis.txt: ci(hypatia): standardise the wrapper caller id to the canonical hypatia

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1m# Exactly one JSON array, with a recognised severity on every finding.�[0m
 �[36;1m# Missing/truncated output is a scanner error, never an empty clean scan.�[0m
 �[36;1mif [ ! -s hypatia-findings.json ] || ! jq -e -s '�[0m
 �[36;1m  length == 1 and (.[0] | type == "array" and all(.[];�[0m
 �[36;1m    type == "object" and (.severity as $s |�[0m
 �[36;1m      ["critical", "high", "medium", "low", "info", "informational"] | index($s) != null)))�[0m
 �[36;1m' hypatia-findings.json >/dev/null; then�[0m
 �[36;1m  echo "::error::Hypatia did not produce one valid findings array"�[0m

GitHub Actions: Static Analysis Gate / 1_Hypatia neurosymbolic scan.txt: ci(hypatia): standardise the wrapper caller id to the canonical hypatia

Conclusion: failure

View job details

##[group]Run set +e
 �[36;1mset +e�[0m
 �[36;1mHYPATIA_FORMAT=json "$HOME/hypatia/hypatia-cli.sh" scan . --exit-zero > hypatia-findings.json�[0m
 �[36;1mHYP_EXIT=$?�[0m
 �[36;1mset -e�[0m
 �[36;1m�[0m
 �[36;1m# --exit-zero is Hypatia's own documented CI recipe (lib/hypatia/cli.ex),�[0m
 �[36;1m# for exactly this case: "use in CI when a downstream step gates on�[0m
 �[36;1m# severity counts". Findings go to stdout, the one-line summary to�[0m
 �[36;1m# stderr, and the process exits 0 unless the SCANNER itself failed.�[0m
 �[36;1m#�[0m
 �[36;1m# Do NOT redirect stderr into the payload with `2>&1`: that folds the�[0m
 �[36;1m# summary line into the JSON, so every parse fails, the old `[]`�[0m
 �[36;1m# fallback substituted a clean result, CRITICAL was always 0, and the�[0m
 �[36;1m# gate below could never fire on any input. Keep stderr on the log.�[0m
 �[36;1mif [ "$HYP_EXIT" -ne 0 ]; then�[0m
 �[36;1m  echo "::error::Hypatia scanner execution failed with exit ${HYP_EXIT}"�[0m
🧰 Additional context used
🪛 GitHub Actions: Workflow Security Linter / 0_lint-workflows.txt
.github/workflows/hypatia-scan.yml

[error] 1-1: SPDX license header check failed: missing '# SPDX-License-Identifier: MPL-2.0' as the first line. The header-check command exited with code 1.

🪛 GitHub Actions: Workflow Security Linter / lint-workflows
.github/workflows/hypatia-scan.yml

[error] 1-1: SPDX license header check failed: missing '# SPDX-License-Identifier: MPL-2.0' as the first line. Failed command: SPDX License Headers check.

🔇 Additional comments (1)
.github/workflows/hypatia-scan.yml (1)

21-21: 🎯 Functional Correctness

The workflow contains no stale reference to the old scan job ID. The only scan match is part of the reusable workflow filename hypatia-scan-reusable.yml; no needs dependency or jobs.scan expression requires an update.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the configuration for an internal automated workflow. It continues to use the same process, with no changes to the app’s features or behaviour for end users.

Walkthrough

The Hypatia scan workflow job key changes from scan to hypatia. The reusable workflow reference remains unchanged.

Changes

Hypatia scan workflow

Layer / File(s) Summary
Rename the workflow job
.github/workflows/hypatia-scan.yml
The job key changes from scan to hypatia. The reusable workflow reference remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c06d0

The rename aligns the caller job with the intended Hypatia check context without changing its reusable workflow. No actionable merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to c06d0

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/hypatia-scan.yml: Renamed the workflow job from scan to hypatia; the reusable workflow reference is unchanged.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the rename and its purpose, but the required template sections are incomplete. The Summary and Changes sections contain no completed content, the Testing section is blank, the… Complete the Summary and Changes sections. State how the change was tested, or explain why testing is not applicable. Complete the required and applicable checklist items. Add screenshots or terminal output if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Hypatia CI wrapper caller ID change and matches the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the rename and its purpose, but the required template sections are incomplete. The Summary and Changes sections contain no completed content, the Testing section is blank, the Screenshots section is blank, and all checklist items remain unchecked.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🛠️ Fix failing CI checks
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow line,
The job key now reads “hypatia” fine.
The reusable call stays as before,
No other change is at the door.
The rabbit hops through fields of green,
With one small rename on the screen.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ Coding Agent task started: View task and status

The task will inspect the CI failures, validate its fix, and commit the fix to this branch automatically.

Note: Fixing CI failures is a beta feature and may encounter errors. Expect some limitations and changes as we gather feedback and continue to improve it.

@hyperpolymath
hyperpolymath merged commit ea6674c into main Oct 1, 2026
51 of 53 checks passed
@hyperpolymath
hyperpolymath deleted the fix/hypatia-caller-id branch October 1, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant