Skip to content

fix(ffi): prevent Zig 0.15 stack overflow in AMQP/Diode reset by using @memcpy #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Aug 24, 2026
Merged

fix(ffi): prevent Zig 0.15 stack overflow in AMQP/Diode reset by using @memcpy #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94962f7
chore(security): triage and resolve panic-attack findings (fixes #12)
hyperpolymath Aug 24, 2026
1077885
fix(ffi): prevent Zig 0.15 stack overflow in AMQP/Diode reset by usin…
hyperpolymath Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 25 additions & 72 deletions audits/assail-classifications.a2ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,72 +1,25 @@
;; SPDX-License-Identifier: MPL-2.0
;; Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk>

(assail-classifications
(metadata
(version "1.0.0")
(project "proven-servers")
(last-updated "2026-05-26")
(entries 10)
(status "active"))

(classification
(file "bindings/rust/src/ffi_smtp.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_ftp.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_grpc.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_mqtt.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_firewall.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_ssh.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/core.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_graphql.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_dns.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
(classification
(file "bindings/rust/src/ffi_macros.rs")
(category "UnsafeCode")
(classification "legitimate-ffi")
(audit "audits/audit-ffi-2026-05-26.md")
(rationale "Rust FFI bindings to libproven-servers (SMTP/FTP/gRPC/etc.) — every unsafe block is an extern "C" call or buffer-ownership transition governed by the C ABI; underlying logic is in formally-verified Idris2."))
)
%A2ML
- suppression:
file: 'bindings/ruby/lib/proven_servers/grpc.rb'
rule: 'DynamicCodeExecution'
justification: 'Ruby metaprogramming used for GRPC dynamic method dispatch; inputs are constrained to schema.'
- suppression:
file: 'protocols/proven-socks/src/SOCKS/Types.idr'
rule: 'HardcodedSecret'
justification: 'False positive: Idris2 type definitions matching heuristic keywords, no actual secrets.'
- suppression:
file: 'protocols/proven-kms/src/KMS/Types.idr'
rule: 'HardcodedSecret'
justification: 'False positive: Idris2 type definitions matching heuristic keywords, no actual secrets.'
- suppression:
file: 'protocols/proven-radius/src/RADIUS/Types.idr'
rule: 'HardcodedSecret'
justification: 'False positive: Idris2 type definitions matching heuristic keywords, no actual secrets.'
- suppression:
file: 'protocols/proven-authserver/src/Authserver/Types.idr'
rule: 'HardcodedSecret'
justification: 'False positive: Idris2 type definitions matching heuristic keywords, no actual secrets.'
- suppression:
file: 'not-proven/proven-ssh-bastion/src/SSH/Auth.idr'
rule: 'HardcodedSecret'
justification: 'False positive: Idris2 type definitions matching heuristic keywords, no actual secrets.'
14 changes: 7 additions & 7 deletions protocols/proven-amqp/ffi/zig/src/amqp.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ pub export fn amqp_create(

for (&sessions, 0..) |*s, i| {
if (!s.active) {
s.* = empty_session;
@memcpy(std.mem.asBytes(s), std.mem.asBytes(&empty_session));
@memcpy(s.vhost[0..vhost_len], vhost_ptr[0..vhost_len]);
s.vhost_len = vhost_len;
s.frame_max = if (frame_max == 0) 131072 else frame_max;
Expand All @@ -458,7 +458,7 @@ pub export fn amqp_destroy(slot: c_int) callconv(.c) void {
mutex.lock();
defer mutex.unlock();
if (slot < 0 or slot >= MAX_SESSIONS) return;
sessions[@intCast(slot)] = empty_session;
@memcpy(std.mem.asBytes(&sessions[@intCast(slot)]), std.mem.asBytes(&empty_session));
}

// -- State queries ------------------------------------------------------------
Expand Down Expand Up @@ -951,12 +951,12 @@ pub export fn amqp_cleanup(slot: c_int) callconv(.c) u8 {

// Clear all session state
sessions[idx].state = .idle;
sessions[idx].channels = [_]Channel{empty_channel} ** MAX_CHANNELS;
@memcpy(std.mem.asBytes(&sessions[idx].channels), std.mem.asBytes(&empty_session.channels));
sessions[idx].channel_count = 0;
sessions[idx].exchanges = [_]ExchangeEntry{empty_exchange} ** MAX_EXCHANGES;
sessions[idx].queues = [_]QueueEntry{empty_queue} ** MAX_QUEUES;
sessions[idx].bindings = [_]BindingEntry{empty_binding} ** MAX_BINDINGS;
sessions[idx].consumers = [_]ConsumerEntry{empty_consumer} ** MAX_CONSUMERS;
@memcpy(std.mem.asBytes(&sessions[idx].exchanges), std.mem.asBytes(&empty_session.exchanges));
@memcpy(std.mem.asBytes(&sessions[idx].queues), std.mem.asBytes(&empty_session.queues));
@memcpy(std.mem.asBytes(&sessions[idx].bindings), std.mem.asBytes(&empty_session.bindings));
@memcpy(std.mem.asBytes(&sessions[idx].consumers), std.mem.asBytes(&empty_session.consumers));
sessions[idx].consumer_count = 0;

return 0;
Expand Down
4 changes: 2 additions & 2 deletions protocols/proven-diode/ffi/zig/src/diode.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ pub export fn diode_create(direction: u8, protocol: u8) callconv(.c) c_int {

for (&gateways, 0..) |*gw, i| {
if (!gw.active) {
gw.* = empty_gateway;
@memcpy(std.mem.asBytes(gw), std.mem.asBytes(&empty_gateway));
gw.direction = @enumFromInt(direction);
gw.protocol = @enumFromInt(protocol);
gw.state = .configured;
Expand All @@ -255,7 +255,7 @@ pub export fn diode_destroy(slot: c_int) callconv(.c) void {
mutex.lock();
defer mutex.unlock();
if (slot < 0 or slot >= MAX_GATEWAYS) return;
gateways[@intCast(slot)] = empty_gateway;
@memcpy(std.mem.asBytes(&gateways[@intCast(slot)]), std.mem.asBytes(&empty_gateway));
}

// -- State queries ------------------------------------------------------------
Expand Down
Loading