Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #283

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f8e7b92e-d296-444d-8e51-cd331fb754df

📥 Commits

Reviewing files that changed from the base of the PR and between d67106c and 40c5e38.

📒 Files selected for processing (3)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml
  • .github/workflows/rust-ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (21)
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Groove manifest check
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Validate K9 contracts
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Validate eclexiaiser manifest
🔇 Additional comments (3)
.github/workflows/governance.yml (1)

21-24: LGTM!

.github/workflows/mirror.yml (1)

20-23: LGTM!

.github/workflows/rust-ci.yml (1)

22-25: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Corrected workflow permission scoping for governance, mirroring, and Rust CI automation.
    • Existing permission levels remain unchanged, while permissions now apply correctly to the relevant jobs.

Walkthrough

Three GitHub Actions jobs now declare their existing permissions at job level. The permission values remain actions: read, contents: read, and security-events: write.

Changes

Workflow permission scope correction

Layer / File(s) Summary
Correct job-level permission declarations
.github/workflows/governance.yml, .github/workflows/mirror.yml, .github/workflows/rust-ci.yml
The three jobs now place their unchanged permissions blocks directly within the job scope.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI permissions indentation fix and the resulting invalid YAML issue.
Description check ✅ Passed The description directly explains the invalid YAML, the indentation correction, the affected permissions, and the validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow lines
Permissions sit where YAML defines
Read actions, contents too
Security events can write anew
Three jobs now follow the signs

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 84b2cb0 into main Sep 21, 2026
19 of 24 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant