style(ncl): format Nickel files with nickel format - #195
Conversation
All 11 genuine Nickel files in the template fail `nickel format --check`, so every repo seeded from this template inherits the defect and goes red on the ci-pipeline Nickel gate over boilerplate it did not write. Fixing it here stops the defect propagating to new seeds. Formatting only. Verified semantics-preserving by comparing the parsed AST: `nickel pprint-ast` output is byte-identical for 11 of 11 files before and after. SPDX and copyright headers are unchanged, and the total comment-line count is identical (356 before, 356 after). Run with the pipeline's own pinned nickel 1.18.0 (sha256-verified), because formatter output differs between releases. The 18 `*.k9.ncl` files are untouched: they are k9 contracts, not Nickel source, and are excluded by hyperpolymath/standards#985. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ji1bq3TypfycfUPAR7hSxR
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (38)
|
| Layer / File(s) | Summary |
|---|---|
Contract schema and runner formatting .machine_readable/contractiles/_base.ncl, .machine_readable/contractiles/*/*.ncl |
Reformats shared schemas and contract configurations. Fields, defaults, controls, security settings, and runner behaviour remain unchanged. |
Coaptation evaluation and witness formatting .machine_readable/coaptation/coapt.ncl, .machine_readable/coaptation/grades.ncl, .machine_readable/coaptation/witness-map.ncl |
Reformats conditional expressions, evaluation records, grade mappings, witness arrays, and record layout. Evaluation logic and witness content remain unchanged. |
Arrival-pack binding formatting .machine_readable/arrival-pack/arrival-pack.ncl |
Condenses the bindings and provenance interpolation. The imported path, pin, and interpolated fields remain unchanged. |
Priority: ⬇️ Low
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Refactor
Suggested reviewers: {{owner}}
Merge Risk: ⚪ Minimal · up to 2eba8
This change normalizes Nickel formatting without altering configuration values or runtime behavior, so it is ready to merge.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the main change: formatting Nickel files with the Nickel formatter. |
| Description check | ✅ Passed | The description clearly explains the purpose, scope, excluded files, and verification results. It does not use the template headings or include the completed checklist, but the content is sufficiently… |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🛠️ Fix failing CI checks
- Commit to this branch
- Create a new PR
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.
Comment @coderabbitai help to get the list of available commands.
|
✅ Coding Agent task started: View task and status The task will inspect the CI failures, validate its fix, and commit the fix to this branch automatically.
|
|



Formatting only — all 11 genuine Nickel files in the template fail
nickel format --check.This is where the defect originates. Every repo seeded from this template
inherits these files, so each one goes red on the ci-pipeline Nickel gate over
boilerplate it did not write.
cicd-squabbleris the measured case(hyperpolymath/cicd-squabbler#106) — it went 100% red on template files, never on
its own source. Fixing the template stops the defect propagating to new seeds.
The other half of that red was a defect in the shared gate itself, fixed in
hyperpolymath/standards#985: it globbed
*.ncl, so it also checked the 18*.k9.nclk9 contracts here — a different format (K9!sentinel on line 1)that can never pass
nickel typecheck. Those 18 files are untouched by this PR.Verification
Run with the pipeline's own pinned nickel 1.18.0 (sha256-verified from the
workflow), not a local build — formatter output differs between releases.
nickel pprint-astbyte-identical before vs after*.nclnickel format --checkafterThe AST comparison is the point: this is provably a cosmetic reformat, not a
semantic change.
Not an auto-fix
No
--fixruns in CI. The pipeline still uses--checkonly; this is adeliberate commit in a reviewable PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ji1bq3TypfycfUPAR7hSxR