Repository navigation
chore(rulesets): retire deadlocked Optimus-Branch and adopt canonical base.json - #199
Merged
Merged
Conversation
… base.json Removes .github/rulesets/Optimus-Branch.json, which had been retired in #97 but was accidentally resurrected by merge of an older branch. Adopts canonical base.json from hyperpolymath/standards/config/rulesets/base.json and updates .github/rulesets/README.adoc. Addresses the template artifact defect linked to #198 so freshly minted repositories do not inherit unmergeable or deadlocked rulesets. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This resolves the template artifact defect connected to #198 so freshly minted repositories from
rsr-template-repoinherit valid, satisfiable rulesets rather than deadlocked configurations:.github/rulesets/Optimus-Branch.json: This file had previously been retired in chore(rulesets): retire Optimus-Branch from the template #97 (per upstreamhyperpolymath/standards#789ruling R1), but was accidentally resurrected during the merge of docs(machine-readable): point at the DEED grammar as the single normative source #76. It containedallowed_merge_methods: [],bypass_actors: [],require_code_owner_review: true, andrequired_approving_review_count: 2, which renders any newly created repo permanently unmergeable..github/rulesets/base.json: Sourced directly from upstreamhyperpolymath/standards/config/rulesets/base.json(§7.3). It configures the default branch baseline with squash merge, deletion protection, non-fast-forward protection, and valid bypass actors, without the retired/unsatisfiablecode_coverageorcode_qualityrules..github/rulesets/README.adoc: Corrects the file list and example POST/PUT commands to point tobase.jsonandImmutable-Tags.jsoninstead of the deletedtag-protection.json.Verification
bash scripts/validate-template.shPASS (0 errors)bash tests/shape/check_root_shape_test.shPASSbash tests/shape/repo_map_determinism_test.shPASS