Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #125

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d65051c8-f8ab-4764-a610-00a1c06bf7b1

📥 Commits

Reviewing files that changed from the base of the PR and between 0f15c61 and 4e5427f.

📒 Files selected for processing (3)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml
  • .github/workflows/scorecard.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (14)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: estate-audit
🔇 Additional comments (3)
.github/workflows/governance.yml (1)

20-23: LGTM!

.github/workflows/mirror.yml (1)

16-19: LGTM!

.github/workflows/scorecard.yml (1)

20-23: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated workflow permission declarations for governance, mirroring, and scorecard automation.
    • Corrected permission scoping to ensure security scanning and related workflow tasks run with the required access.

Walkthrough

The governance, mirror, and scorecard workflows now place their permission declarations at job level. Each job grants actions: read, contents: read, and security-events: write.

Changes

Workflow permissions

Layer / File(s) Summary
Job-level permission declarations
.github/workflows/governance.yml, .github/workflows/mirror.yml, .github/workflows/scorecard.yml
The three jobs now define actions: read, contents: read, and security-events: write under the job-level permissions key.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: correcting permissions block indentation that caused invalid YAML in CI workflows.
Description check ✅ Passed The description accurately explains the invalid YAML, the indentation correction, the preserved permission grants, and the affected workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions now sit in the right place
Actions read and contents read
Security events can be fed
Three neat jobs hop into place

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit d2a96db into main Sep 21, 2026
13 of 17 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant