Skip to content

All 12 Rust crates fail cargo fmt --check (pre-existing formatting debt) #933

Description

@hyperpolymath

Summary

Every one of the 12 tracked Rust crates fails cargo fmt --check when run from its own directory. This is genuine pre-existing formatting debt in committed source, not a tooling error — rustfmt resolves and runs, and the diffs are real line reflows.

Filed per the standing rule that a new scanner finding is an issue, not a blocker. No source was reformatted — the spec bars modifying existing core logic or source files, and cargo fmt without --check is an auto-fix flag.

Measured evidence

rustfmt 1.9.0-stable, each crate entered by cd to its own manifest directory:

.verisimdb/ecosystem-ingest                                      FAILS fmt
1-formats/sub-specs/inline-annotations/extractor                 FAILS fmt
2-protocols/k9-coordination/tools/k9-init                        FAILS fmt
hooks/playbook-to-recipe                                         FAILS fmt
rhodium-standard-repositories/examples/ai-ml-project             FAILS fmt
rhodium-standard-repositories/examples/enterprise-service        FAILS fmt
rhodium-standard-repositories/examples/minimal-rust-project      FAILS fmt
rhodium-standard-repositories/examples/rhodium-minimal           FAILS fmt
rhodium-standard-repositories/examples/standard-library          FAILS fmt
rhodium-standard-repositories/satellites/rsr-certifier           FAILS fmt
rhodium-standard-repositories/satellites/rsr-certifier/engine    FAILS fmt
rhodium-standard-repositories/satellites/rsr-certifier/lsp       FAILS fmt

12 of 12. Running from the repo root instead exits rc=1 on could not find Cargo.toml — a different failure, tracked separately in #932. Fix #932 first: until the hook runs cargo per crate, this debt is invisible to it and a "fix" here would be unverifiable.

Acceptance criteria

  • cd <crate> && cargo fmt --all --check exits 0 for all 12 crates.
  • Reformatting lands as its own commit touching only formatting — no logic change in the same commit, so the diff stays reviewable.
  • A rustfmt.toml is added at the repo root (or per crate) if the debt exists because crates currently disagree on style; state which, with evidence, before reformatting.
  • CI runs --check only. No auto-fix flag runs in CI.
  • validate-lint-format.sh: Rust and Nickel arms ask a different question than their tool #932 is resolved first, so the per-crate gate can actually observe the result.

Found while measuring #931.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtKnown shortcut, drift, or hygiene owed - includes cleanup

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions