Repository navigation
test(uuid-v8): three more .in mint-template cases on top of #1258 - #1259
Merged
Merged
Conversation
… becomes rsr-template-repo#238 stays red on "UUID v7 conformance" (the strict v8 gate) because archetypes/julia-library/overlay/Project.toml.in names Test and Aqua by their General-registry UUIDs under [extras]. check-uuid-v8.sh already exempts the [deps], [weakdeps] and [extras] tables of a Project.toml, and all of a Julia Manifest, as external identifiers (ADR-008: preserve and type explicitly). It chose those rules by exact file name, so the .in template that renders to Project.toml was scanned as plain text. scannable_text() now strips one trailing `.in` before choosing the rules. A Project.toml.in keeps the table exemption, and its own top-level `uuid =` is still checked. Any other .in file is scanned as before. - uuid-v8-test.sh: six new cases, all assembled at runtime. A Project.toml.in keeps the exemption, its own v4 uuid is rejected, a Manifest.toml.in is accepted, a [deps] table in a non-Julia .in is rejected, a near-miss `.inx` is rejected, and the rsr-template-repo shape passes under --strict. 38/38 pass. With the old checker the three exemption cases fail. - On rsr-template-repo#238's tree (cfd3ea4), `--strict` now exits 0. The old checker reports exactly the two CI failures (8dfed614…, 4c88cf16…). - On this repo, both modes give identical output to the old checker. Callers get this when they move their governance pin past this commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N6my4F3ohjwFReLW8cYYqC
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
K9 contract conformancerun https://github.com/hyperpolymath/standards/actions/runs/38558949424 K9 normative contract typecheckK9 contract self-testK9 conformance fixturesK9 corpus conformance (L2) |
hyperpolymath
marked this pull request as ready for review
October 14, 2026 11:48
hyperpolymath
enabled auto-merge (squash)
October 14, 2026 11:48
Contributor
K9 contract conformancerun https://github.com/hyperpolymath/standards/actions/runs/38559207158 K9 normative contract typecheckK9 contract self-testK9 conformance fixturesK9 corpus conformance (L2) |
…p the extra tests #1258 landed the same `.in` mint-template rule in check-uuid-v8.sh, so the checker is taken from main unchanged. In the test file, main's three .in cases are kept and this branch adds the three it lacked: - a Manifest.toml.in is accepted; - a near-miss Project.toml.inx is not exempt; - the rsr-template-repo#238 shape (v5 registry UUIDs in a Project.toml.in [extras]) passes under --strict. uuid-v8-test.sh 38/38, check-uuid-v8-domains-test.sh 23/23, and check-uuid-v8.sh --strict . on this repo is clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N6my4F3ohjwFReLW8cYYqC
hyperpolymath
changed the title
|
Contributor
K9 contract conformancerun https://github.com/hyperpolymath/standards/actions/runs/38559735889 K9 normative contract typecheckK9 contract self-testK9 conformance fixturesK9 corpus conformance (L2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is now
hyperpolymath/standards#1258 landed the same checker fix while this PR was open. A
<name>.inmint template is now scanned under<name>'s rules, which clears theProject.toml.infailure on hyperpolymath/rsr-template-repo#238.Commit
a97f2220resolves the conflict:scripts/check-uuid-v8.shis taken frommainunchanged.main's three.intest cases are kept.The PR's whole diff against
mainis now nine lines inscripts/tests/uuid-v8-test.sh. They add the three casesmainlacks:Manifest.toml.inis accepted, as a Manifest is;Project.toml.inxis not exempt, so a future change that widens the suffix match fails;[extras]of aProject.toml.in) passes under--strict, the mode the governance gate runs.Verification
uuid-v8-test.sh: 38 of 38.check-uuid-v8-domains-test.sh: 23 of 23.check-uuid-v8.sh --strict .on this repo is clean.main's checker against rsr-template-repo#238's tree (cfd3ea4) exits 0 under--strict.🤖 Generated with Claude Code
https://claude.ai/code/session_01N6my4F3ohjwFReLW8cYYqC