fix(ci): verify SSH host keys in reusable mirror workflow - #769
Merged
Merged
Conversation
Replaces unchecked ssh-keyscan output with verification against approved, pinned SSH host fingerprints before git push. - Each mirror job verifies host fingerprint before push - GitLab, Bitbucket, Codeberg: default fingerprints with override via vars - SourceHut, Disroot, Gitea: require explicit fingerprint via vars - Uses StrictHostKeyChecking=yes with verified known_hosts - Mirror jobs fail closed on fingerprint mismatch - GitLab mirror remains advisory (continue-on-error) - Added documentation in docs/MIRROR-HOST-VERIFICATION.adoc - Added regression tests in scripts/tests/science-ci-security-test.* Fixes #762 Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Contributor
|
Warning Review limit reachedNext included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #762 - Verify SSH host keys in reusable mirror workflow
Replaces unchecked ssh-keyscan output with verification against approved,
pinned SSH host fingerprints before git push.