fix(docs): resolve two dangling references and the code-scanning alert left by #811 - #813
Merged
Merged
Conversation
…t on this PR
Remaining CI failures on this PR, triaged to source rather than to name.
"HYPATIA" IS NOT A WORKFLOW
Triaged first because it looked like one. No workflow or job in this repository
is named `Hypatia`; the check-run comes from the GitHub Advanced Security app,
i.e. it is the code-scanning gate, and it failed because the SARIF upload from
this PR contained **1 new alert in code changed by this pull request**:
.machine_readable/rsr-profile.a2ml
warning: doc references `src/interface/` but no such directory exists in the
tree (likely surviving a directory rename)
A true positive against my own new file, not a false one. The directory really
is absent (0 tracked files under src/interface/ in the canon), and the sentence
was declaring *that absence* — "no C-ABI seam and no formally specified ABI;
src/interface/ absent" — but written so that it read as a live path reference.
Reworded to state the same fact without the bare path token. The alert was not
dismissed and no scanning config was touched: the text is simply unambiguous now
about what it means.
TWO MORE DANGLING REFERENCES, FOUND WHILE LOOKING
Chasing that alert meant checking every path this PR's files point at, and two
pointed at a document that was never committed — `docs/binding/04-EXECUTION-*`
does not exist, and neither does `docs/binding/`:
.machine_readable/rsr-profile.a2ml:37 "see docs/binding/04-EXECUTION-PLAN.md, ruling R-B"
docs/AFFIRMATION.adoc:54 link:../binding/04-EXECUTION-PLAN.md[...]
scripts/check-canon-lockstep.sh:98 "# See docs/binding/04-EXECUTION-PLAN.md."
These were references to a plan that existed only in conversation. A document
that cites a non-existent authority is worse than one that cites none: it reads
as though the argument has been made somewhere. Repointed at what actually
exists and actually says it:
* the dialect note -> docs/AUDIT.adoc finding F3, which records that the law is
authored in a superseded dialect while DEED is itself an unratified DRAFT
* the ordering rule -> canon.lock [canon.lockstep], which is where
"spine-adopts-then-canon-releases" is actually stated
* AFFIRMATION's "We intend" list -> docs/AUDIT.adoc, which enumerates the
release conditions those actions serve
A scan of every cross-reference in every .adoc and .a2ml this PR touches now
resolves; earlier it did not.
NO LOCK BUMP REQUIRED
`.machine_readable/rsr-profile.a2ml` is not named in canon.lock [canon.artifacts]
(criteria, gates, applicability, lifecycle, constitution), so a comment edit in it
is not a canon change and Gate A assertion 2 stays satisfied.
GATES AFTER
Gate A, --canon standards -> passed 8 failed 0 skipped 2 GATE A PASSED
Gate A, --canon . -> passed 8 failed 0 skipped 2 GATE A PASSED
check-rsr-profile.sh . -> OK — scaffold matches declared capabilities
check-standards-map.sh -> GATE D PASSED, entry_count = 120
(cherry picked from commit 236fcb8)
Contributor
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
hyperpolymath
enabled auto-merge (squash)
September 17, 2026 17:59
hyperpolymath
disabled auto-merge
September 17, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #811, which merged at
ca1c24e. This is the one commit from that branch that was not part of the merge:236fcb8.Why this exists
Triage of the remaining CI failures on #811 turned up two defects in the merged work itself. Both are still live on
main.1.
Hypatiawas not a workflowI triaged it last because it looked like an unrelated pre-existing failure. No workflow or job in this repository is named
Hypatia. The check-run comes from the GitHub Advanced Security app — it is the code-scanning gate, and it failed because the SARIF upload from #811 contained 1 new alert in code changed by this pull request:A true positive against a file #811 added. The directory really is absent (0 tracked paths under
src/interface/, and the canon has none). The sentence was declaring that absence — "no C-ABI seam and no formally specified ABI; src/interface/ absent" — but written so it read as a live path reference. Reworded to state the same fact without the bare path token.The alert was not dismissed and no scanning configuration was touched. The text is simply unambiguous now about what it means.
2. Three references to a document that does not exist
Checking every path that #811's files point at turned up references to
docs/binding/04-EXECUTION-PLAN.md. Neither that file nordocs/binding/exists anywhere in this repository, and never has:.machine_readable/rsr-profile.a2ml:37docs/AFFIRMATION.adoc:54link:../binding/04-EXECUTION-PLAN.md[...]scripts/check-canon-lockstep.sh:98These point at a plan that existed only in conversation. A document citing a non-existent authority is worse than one citing none: it reads as though the argument has been made somewhere. Repointed at what exists and actually says it:
docs/AUDIT.adocfinding F3, which records that the law is authored in a superseded dialect while DEED is itself an unratified DRAFTcanon.lock [canon.lockstep], wherespine-adopts-then-canon-releasesis actually stateddocs/AUDIT.adoc, which enumerates the release conditions those actions serveEvery cross-reference in every
.adocand.a2mlthis commit touches now resolves.No lock bump required
.machine_readable/rsr-profile.a2mlis not named incanon.lock [canon.artifacts](criteria, gates, applicability, lifecycle, constitution), so a comment edit in it is not a canon change and Gate A assertion 2 stays satisfied.Gates