fix(ci): secret-scanner remediation text no longer cites the leak site - #819
Merged
Merged
Conversation
closes #800) The shell-secrets job's remediation message pointed developers at avow-protocol/deploy-repos.sh — the exact file whose leak created this gate (cited twice in this same file's comments as the failure case), and a path removed by #161, so the guidance 404s. Adopt the issue's suggested text: instruct env-sourcing with an inline example and no named file — any named example can rot the same way.
Contributor
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #800.
The defect (re-measured at HEAD
33ec4a7, 2026-09-17)The
shell-secretsjob's remediation message read:That citation fails twice, in the issue's words:
avow-protocol/deploy-repos.shas the failure case this gate was created for — twice, in comments (L17-19, L671).avow-protocol/deploy-repos.shwas removed by security(avow-protocol): remove leaked Cloudflare API token + harden scanner #161;avow-protocol/now holds onlyBINDING.adoc. The guidance cannot be followed even in principle.Fix (the issue's own suggested text)
The citation is dropped rather than repointed — any named example can rot the same way, and the advice needs no example to be actionable. The two comments documenting the leak's history are untouched: they are accurate records of why the gate exists.
Byte-verified: the line is
"/\$-escaped correctly for bash (single backslashes;od -cchecked). One file,+1/-1.