fix(templates): STATE.a2ml.template licence comment must not default mints to PMPL - #835
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The license comment in 1-formats/templates/STATE.a2ml.template (moved from a2ml-templates/ in the district reorg) contradicted itself and the canon: the comment said 'Almost always PMPL-1.0-or-later' while the value shipped two lines down was already license = "MPL-2.0". Mints that followed the prose flipped the correct value to the reserved licence — the exact propagation vector standards#645 hunts. Current canon (verified three ways before touching): LICENCE-POLICY.adoc Rule 2 (PMPL = palimpsest-license, palimpsest-plasma, consent-aware-web ONLY), .machine_readable/licensing-policy.toml (code=MPL-2.0, prose=CC-BY-SA-4.0; warns_on covers stray PMPL), MUST.contractile #93 ('PMPL-1.0-or-later appears in NO standards file'). The comment now states the per-category default and the palimpsest carve-out. Comment/metadata hygiene only — the operative value was already MPL-2.0. (Rebuilt on post-reorg main; path was a2ml-templates/ on the old layout.) Refs #645
hyperpolymath
force-pushed
the
fix/645-scaffold-licence-line
branch
from
September 17, 2026 20:45
ffae312 to
fe9f3ef
Compare
|
13 tasks
hyperpolymath
added a commit
that referenced
this pull request
Sep 17, 2026
#839) …ards#645) Records the verified end-state of the §7a strategy so the next executor does not re-hunt the emitters: rsr-template flipped 2026-05-22 (04997b9), scaffoldia is harvested-registry data (not an emitter), llm-warmup-* is gone (404), the standards-side remnant STATE.a2ml.template:46 was fixed at source in PR #835 (merged today), and axel-protocol's authored trust.txt trio stays per §3. Remaining work is the owner-run §1/§3-excluding re-propagation + residue clean, as designed. Refs #645 <!-- SPDX-License-Identifier: CC-BY-SA-4.0 Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk> --> ## Summary <!-- What does this PR do, and why? --> Closes # ## Type of change - [ ] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) - [ ] 💥 Breaking change (would change existing behaviour) - [ ] 🕳️ Soundness fix (fixes a checker/proof false-negative) - [ ] 📖 Documentation - [ ] 🧹 Refactor / tech debt (behaviour-preserving) - [ ] ⚡ Performance - [ ] 🔧 Build / CI / tooling ## How has this been verified? <!-- Establish ground truth: which tool did you RUN, and what did it report? Don't cite a status doc — cite the command and its output. --> ## Checklist - [ ] My commits are **signed** (`git commit -S`). - [ ] I ran the project's own checks/tests locally and they pass. - [ ] New files carry the correct `SPDX-License-Identifier` (code/config `MPL-2.0`, prose `CC-BY-SA-4.0`); I did not relicense existing files. - [ ] Docs are updated, and no public claim now overstates what the code does. - [ ] I have not introduced a soundness hole (or I have flagged where I might have). ## Notes for reviewers <!-- Anything that needs special attention, follow-up, or context. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #645 (source-side verification + the one genuinely-wrong emitter comment; does NOT close the residue-cleanup fraction).
Candidate-by-candidate verification (before touching anything)
04997b92026-05-22 ("chore: migrate license from PMPL-1.0-or-later to MPL-2.0") flipped humans.txt →License: MPL-2.0 (code) / CC-BY-SA-4.0 (docs)and dep5 → MPL-2.0 — THREE MONTHS before the issue measured the residue (2026-08-26). The 54 files came from an older vintage (2283f12).machine-readable-design/harvested-registry/**.ncl— harvested package-registry RECORDS (data), not templates. Editing would falsify data.llm-warmup,llm-warmup-cccp,llm-warmup-rsrall 404 — cannot be emitting anything today..well-known/,docs/.well-known/,public/.well-known/)spec/*.adoc×6 carry*License*: PMPL-1.0-or-later+ normative markers,docs/CITATIONS.adoc×1,config/metadata.k9.ncl×1. Hand-editing the operative-looking claim = guessing licence authority, which the estate's own rule (debt.a2ml) forbids.license = "MPL-2.0". The prose contradicted three current-canon sources and minted the flip into new repos. The comment now states the per-category rule + palimpsest carve-out.Still open after this PR (issue stays open)
0-ai-gatekeeper-protocol/0-AI-MANIFEST.a2ml:89,261,…/examples/…:46,115,ensaid-config/0-AI-MANIFEST.a2ml:30,37still teach "All code PMPL-1.0-or-later unless platform requires MPL-2.0". These sit on the preference-comment surface the issue itself assigns to the (closed) docs(licence): drop the PMPL preference claim — standards is not a PMPL repo #643 — flagging them here as docs(licence): drop the PMPL preference claim — standards is not a PMPL repo #643-residue candidates for a separate scoped PR rather than smuggling them into this one.Diff: 1 file, +4/−1 (comment/metadata hygiene; the operative value was already MPL-2.0).
Rebuilt 2026-09-17 20:50Z: force-pushed onto post-reorg main (
418d576, canon 2.0.4 district layout) — the file moveda2ml-templates/→1-formats/templates/; the wrong comment survived the move verbatim (lines 46-48 now). Same 1-file +4/−1 fix, new path. Old headffae312was mergeable=dirty against the district reorg and is superseded.