fix(docs-gate): accept root CONTRIBUTING.adoc — 94% of failures were false positives - #850
Merged
Merged
Conversation
…false positives
`have CONTRIBUTING.md 3-practice/CONTRIBUTING.adoc` never accepted a root
CONTRIBUTING.adoc, even though this script's own header states the estate
policy is "AsciiDoc is the default" and README/LICENSE both accept .adoc.
The CONTRIBUTING cutoff armed itself on 2026-08-21 (ENFORCE_CONTRIBUTING_FROM),
so as of today this gate blocks. Measured blast radius, 2026-09-18, random
sample of 40 repos:
passes the gate 6
FALSE POSITIVE (.adoc only) 32
genuinely missing the document 2
i.e. 32/34 = 94% of the repos this gate reports non-compliant do have the
document, at the path the estate actually uses. Every 7 of the currently
conflicted PR repos (bqniser, mylangiser, nextgen-databases, nimiser,
phronesiser, pimcore-fortress, tlaiser) fail on this and on nothing else.
The #505 fixture suite did not catch it: "alternate extensions accepted"
places CONTRIBUTING.adoc only under 3-practice/, never at the root.
Adds two fixtures — root CONTRIBUTING.adoc passes post-cutoff, and still
warns-then-blocks when genuinely absent. Reverting just the gate line makes
the first fixture fail (24/24 -> 23/1), so it is a real regression test.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
hyperpolymath
deleted the
fix/docs-gate-accept-root-contributing-adoc
branch
September 18, 2026 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
have CONTRIBUTING.md 3-practice/CONTRIBUTING.adocwith a version that also accepts a rootCONTRIBUTING.adoc.Why
This script's own header states the estate policy is “AsciiDoc is the default”, and it accepts
README.adocandLICENSE.txt— but for CONTRIBUTING it never accepted a root.adoc.ENFORCE_CONTRIBUTING_FROM=2026-08-21armed itself on that date (“on the cutoff date this check starts failing with no further edit to this file”), so this gate is now blocking.Measured blast radius, 2026-09-18, random sample of 40 repos:
32/34 = 94% of the repos this gate reports as non-compliant do have the document, at the path the estate actually uses. All seven of the currently conflicted-PR repos (
bqniser,mylangiser,nextgen-databases,nimiser,phronesiser,pimcore-fortress,tlaiser) fail on this and on nothing else.Controlled reproduction:
Why the #505 suite did not catch it
The existing “alternate extensions accepted” fixture places
CONTRIBUTING.adoconly under3-practice/, never at the root.Verification
DOCS_TODAY=2026-09-18The revert row is the point: a regression fixture that still passes against broken code proves nothing.