fix(ci): correct the rebar3 guidance — a pin cannot bypass the builds.hex.pm cert error - #853
Merged
hyperpolymath merged 1 commit intoSep 19, 2026
Conversation
….hex.pm cert error
The previous change in this area (and the state it replaced) both assumed the
`rebar3-version` input could steer setup-beam away from `mix local.rebar`, and
that the builds.hex.pm cert error it was added for had gone away. Neither holds,
and the assumption cost bofig three months of red CI.
Measured facts, 2026-09-19, same host, same action pin, same day:
* setup-beam runs `mix local.rebar --force` whenever `install-rebar` is true
(the default), BEFORE it considers `rebar3-version`. So the pin cannot
bypass that call — it is gated only by `install-rebar`, an input this
reusable does not expose.
* the cert error is live, not historical. builds.hex.pm serves a Let's Encrypt
chain (`YR1` intermediate) that older Erlang/OTP builds reject with
`key_usage_mismatch` / `unsupported_certificate`.
* it is OTP-build-specific: OTP 27.3.4.17 (erts-15.2.7.13) fetches from that
host successfully; OTP 27.2.1 (erts-15.2.1) fails. chimichanga passes on the
former while bofig failed on the latter, in the same hour.
* bofig's failures began 2026-06-22, two days BEFORE its rebar3 pin existed,
with the identical error — so the pin neither caused nor fixed them.
- correct the `rebar3-version` description: it installs rebar3 from GitHub
releases and does not replace `mix local.rebar`; pass `github-token` when set
- replace the catalog note with the measured account and the actual remedy
(bump `otp-version` to a current patch; or `install-rebar: false` to skip the
call), including the ordering detail that makes the pin useless as a workaround
hyperpolymath
deleted the
fix/elixir-reusable-correct-the-rebar3-guidance
branch
September 19, 2026 08:47
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The change that just landed in this area (and the text it replaced) both assumed
rebar3-versionsteered setup-beam away frommix local.rebar, and that the builds.hex.pm cert error it was written for had gone away. Neither holds, and the assumption kept bofig's CI red for three months.What was actually measured (2026-09-19, same host, same action pin, same hour)
rebar3-versionreplacesmix local.rebarmix local.rebar --forcewheneverinstall-rebaris true (the default), before it considersrebar3-version. The pin is gated by nothing; the mix call is gated byinstall-rebar.YR1intermediate) that older OTP builds reject:{:tls_alert, {:unsupported_certificate, {key_usage_mismatch, ...}}}→Could not install Rebar because Mix could not download metadata at https://builds.hex.pm/installs/rebar3-1.x.csv.Changes
rebar3-versiondescription rewritten: it installs rebar3 from GitHub releases (authenticated lookups needgithub-token), and it does not replacemix local.rebar.otp-versionto a current patch release, or setinstall-rebar: falseto skip the call — plus the ordering detail that makes the pin useless as a workaround.Verification
actionlintclean; nouses:change, soactions.lockneeds no regeneration.Companion
bofig carried this fix downstream already (
bofig#197, OTP bump): itselixir.ymlis green onmainfor the first time since June, including the test suite.