Skip to content

fix(hooks): validate-bot-directives scans .deed too (W1 gate-sorting for #837) - #855

Merged
hyperpolymath merged 1 commit into
mainfrom
gates-dual-accept-deed
Sep 19, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
gates-dual-accept-deed

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Wave 1 (gate sorting) of the estate-wide DEED conversion campaign (#837).

Gates must dual-accept before translation waves land, or every converted file goes red. Inventory of standards' gate plumbing (grepped at 699c47f):

  • pre-commit / pre-push A2ML gates — removed by your own R-H3 ruling; comments only ✅
  • validate-bot-directives.sh — the only live find-glob over manifest files left → this PR adds -o -name '*.deed' (parity-only; staged-mode extension list untouched — it never listed .a2ml either)
  • the 8 manifest-consuming workflows reference specific filenames (Debtfile, REGISTRY, CLAIMS, INDEX, ECOSYSTEM, rsr-criteria-v2, launcher-standard, PROVENANCE) — those update in the same PR as each family's translation per the campaign rule, not here

Already dual-accept elsewhere: rsr validate-deed.sh (rsr#156), deed-ecosystem validate-action.

Local test: .machine_readable/ with paired SAMPLE.a2ml + SAMPLE.deed → both picked up by the scan branch. Commit gate: 1 file, 1 line.

This is the first mechanical unit of the migration plan (estate census: 20,881 .a2ml files across 323 repos; full plan in my workspace ledger — campaign surface stays in this issue).

…for #837)

Wave 1 of the estate-wide DEED conversion campaign (#837): gates must
dual-accept before translation waves land, or every converted file goes
red. This was the only live find-glob over manifest files left in
standards' gate plumbing (the pre-commit/pre-push A2ML gates were
removed by R-H3; rsr's validate-deed.sh and deed-ecosystem's
validate-action are already dual-accept). Parity-only: staged-mode
extension list untouched (it never listed .a2ml either).

Local test: .machine_readable/ with paired SAMPLE.a2ml + SAMPLE.deed
-> both picked up by the machine-readable scan branch.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 24a5c4c6-6e0d-4c11-ac32-77a86c96e1e0

📥 Commits

Reviewing files that changed from the base of the PR and between 699c47f and 96a42a9.

📒 Files selected for processing (1)
  • .githooks/validate-bot-directives.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (19)
  • GitHub Check: analyze-actions / analyze
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scorecard / Run Scorecard PR
  • GitHub Check: scan / gitleaks
  • GitHub Check: analyze-js / analyze
  • GitHub Check: ci / Detect mix.exs
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: SPARK Theatre Gate
  • GitHub Check: AffineScript Verify
  • GitHub Check: Detect proof changes
  • GitHub Check: Verify CLAIMS.a2ml + conformance
  • GitHub Check: Registry + topology in sync
  • GitHub Check: K9-SVC contractile validation
  • GitHub Check: Scan for hand-authored JavaScript/TypeScript
  • GitHub Check: Check Documentation Format
  • GitHub Check: uses ⊆ actions.lock
  • GitHub Check: Lockfile self-consistency
  • GitHub Check: Repo self-tests
🔇 Additional comments (1)
.githooks/validate-bot-directives.sh (1)

38-38: LGTM!


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Validation now also checks .deed files in .machine_readable directories when no specific staged files are provided.

Walkthrough

Changes

Bot directive validation

Layer / File(s) Summary
Extend machine-readable file scanning
.githooks/validate-bot-directives.sh
The validation scan now checks *.deed files in .machine_readable directories, in addition to *.a2ml, *.md, and *.txt files.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: joshuajewell

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the hook change: validate-bot-directives now scans .deed files. It is concise and related to the main change.
Description check ✅ Passed The description accurately explains the migration context, the exact script change, scope boundaries, and local test result.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit found a deed in the burrow bright
The checker now reads it by morning light
Old directives hop into view
Along with notes and text files too
The migration bounds grow neat and tight

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 9f68279 into main Sep 19, 2026
24 of 30 checks passed
@hyperpolymath
hyperpolymath deleted the gates-dual-accept-deed branch September 19, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant