fix(profile): rsr-profile.a2ml comment dialect — // to # (record dialect) - #859
Merged
Merged
Conversation
…ect) The a2ml record dialect uses # comments; this file carried 102 line and 106 inline // comments, which RecordDialect.parse/1 rejects — so the canon's own profile was unreadable and every scorecard ran profile=false (the law not subject to the law). Conversion is string-aware and comment-aware (quotes inside comments do not open strings; no // inside a quoted value was touched). Acceptance (measured with hypatia 2026-09-19): RecordDialect.parse OK, scorecard flips profile=true — canon 68.53%, the 15-criterion governance remediation list. No [canon] hash values changed here; those move with the MINOR (canon.lock same-commit protocol).
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
….1.0 release) (#860) **Merges second in the canon train** (after the profile-dialect fix, which is its base). Adds 5.2.3 `julia-package` (silver), 5.2.4 `julia-ci` (bronze), 5.2.5 `julia-aqua` (gold), 5.2.6 `julia-docs` (silver) - all `gate = "julia"`, so non-regression holds by construction: a repo that does not declare `julia` has the new criteria scored `na`. The 33-repo `.jl` estate goes from invisible to checkable. Also: gate-table rows (Project.toml, test/, the two julia workflows → julia; the `julia-library` preset pre-exists - verified), policy mirror sync, and the canon-v2.1.0 lockstep release commit (canon.lock version/hash rewrite per the [canon.artifacts] same-commit protocol; Gate A [1]+[2] PASS locally). Precondition: the spine's adoption PR (rsr-template-repo, canon-2.1.0-adoption) must land first. Owner ruling 2026-09-19: approved. --------- Co-authored-by: hyperpolymath-recon <recon@hyperpolymath.dev>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The a2ml record dialect uses
#; this file carried 102 line and 106 inline//comments whichRecordDialect.parse/1rejects - so the canon's own profile was unreadable and every scorecard ranprofile=false(the law not subject to the law).Conversion is string- and comment-aware. Acceptance measured with hypatia 2026-09-19: parse OK, scorecard flips profile=true (canon 68.53%, the 15-criterion governance remediation list).
No [canon] hash values changed here; those move with the MINOR. Base of the canon train.