fix(ci): align two straggler action pins to the lockfile standard (cures the main-gate failure) - #866
Merged
Merged
Conversation
The Actions Lockfile Gate (uses ⊆ actions.lock) has been failing on main since deed-conformance.yml and tag-ruleset-canon.yml landed with pins that were never keyed: deed-conformance.yml actions/checkout@8e8c483… (v6.0.1) tag-ruleset-canon.yml actions/upload-artifact@ea165f8… (v4.6.2) Both workflows now use the estate-standard pins already present in .github/workflows/actions.lock: actions/checkout@3d3c42e5… # v7.0.1 (keyed; ~30 workflows) actions/upload-artifact@043fb46… # v7.0.1 (keyed; apply-workflow-pins, echidna-verify) The lockfile itself is unchanged — the canonical fix per the gate's own regeneration contract (lock is the SSOT; workflow pins must match it). The alternative (keying the old SHAs in the lock) was rejected: it would entrench deprecated pins (checkout v6, upload-artifact v4 — v4 is end-of-life) as estate standard. Verified locally: bash .githooks/validate-actions-lock.sh → ✅ 23 SHA-pinned ref(s) found among 23 lockfile keys, 2 doctrine exception(s) (exit 0; was 2 errors) git diff --stat -- .github/workflows/actions.lock → empty
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (21)
🔇 Additional comments (2)
📝 SummarySummary by CodeRabbit
WalkthroughTwo GitHub Actions references now use newer pinned versions. Workflow logic, inputs, conditions, and gate behaviour remain unchanged. ChangesWorkflow action updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the pins in line Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Actions Lockfile Gate(uses ⊆ actions.lock) has been failing on every run sincedeed-conformance.ymlandtag-ruleset-canon.ymllanded with pins that were never keyedin
.github/workflows/actions.lock:deed-conformance.ymlactions/checkout@8e8c483…(v6.0.1)actions/checkout@3d3c42e5…(v7.0.1)tag-ruleset-canon.ymlactions/upload-artifact@ea165f8…(v4.6.2, EOL)actions/upload-artifact@043fb46…(v7.0.1)Both replacement SHAs are already keyed in the lock (checkout v7.0.1 is the estate
standard in ~30 workflows; upload-artifact v7.0.1 is keyed and used by
apply-workflow-pins.yml+echidna-verify.yml). The lockfile is unchanged: thegate's own contract is that the lock is the SSOT and workflow pins must match it.
The alternative (keying the old SHAs in the lock) was deliberately rejected: it would
entrench deprecated pins (checkout v6, upload-artifact v4) as estate standard — exactly
the failure mode the gate exists to prevent.
Note: this is not a #865 e-pin issue — the gate skips cross-repo
*/.github/workflows/*refs by design; those were never the failing refs.Verification
Risk
Low. Both workflows inherit the exact pins used estate-wide; no job logic changes.