fix(audit): correct the census total to 333, and the stale #17 tense in the gate header - #871
Merged
Merged
Conversation
Two self-inflicted defects in the previous commit, both caught by re-reading the
artefacts against the census data they quote:
* the audit said "337 required contexts across 179 repositories"; the census
(census verdicts app-owned 168 + producible 156 + app-named 4 + unsatisfiable
5) totals 333. A census document that miscounts its own census is exactly the
kind of unverified claim this estate's audit gate exists to prevent.
* the gate's header still described tropical-types#17 in the present tense
("the wrapper publishes `scan / ...`"). That repository now publishes both the
bare name (inline job) and the prefixed name (wrapper caller `hypatia`), so the
sentence was stale the moment it merged.
Also records that all five unsatisfiable contexts bind `integration_id: 15368`
(GitHub Actions): they are repository-owned workflow job names, which is why no
external publisher could satisfy them, and why the fix is a rename rather than an
app configuration change.
The header still read "while the wrapper publishes `scan / Hypatia Neurosymbolic Analysis`". That repository publishes the bare name from an inline job and the prefixed name from its wrapper caller now, so the sentence described a condition that no longer exists. Split out from the census-count correction because the previous attempt at it matched the wrong text and silently changed nothing.
Contributor
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The census reads each repository's default-branch workflow set, so a required context held by a ruleset bound to some other ref could have been reported as a defect it never was. Re-checked all five against the ruleset that carries them: active enforcement, `~DEFAULT_BRANCH` in every `ref_name.include`, single-branch repositories, and `integration_id: 15368` on every context. The five are live defects. Also notes that three of them are guarded by a ruleset named `Optimus-Branch` that binds the default branch — the same conflation of "this branch" with "that branch" that produced the class.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two self-inflicted defects in the artefacts that merged as #869, both caught by re-reading them against the census data they quote.
1. The audit miscounted its own census. It said 337 required contexts across 179 repositories; the verdicts it prints alongside (app-owned 168 + producible 156 + app-named 4 + unsatisfiable 5) total 333. Corrected, plus the fact that all 333 were ruleset-sourced, so no repository in the census still enforced required status checks through legacy branch protection.
2. The gate's header described
hyperpolymath/tropical-types#17in the present tense ("the wrapper publishesscan / Hypatia Neurosymbolic Analysis"). That repository publishes the bare name from an inline job and the prefixed name from its wrapper caller now — the sentence was stale on merge.Also records why the five unsatisfiable contexts matter rather than being app-configuration work: every one binds
integration_id: 15368(GitHub Actions), so they are repository-owned workflow job names. No external publisher could ever satisfy them, and the fix is a rename or a re-armed rule, not a settings tweak.Why it is worth a PR rather than a quiet push
The whole point of this audit is that unverified claims about CI state are how a required context becomes unsatisfiable without anyone noticing. A census document that miscounts its own census, and a header that describes a fixed condition as live, are the same failure at one remove.
Verification
bash scripts/tests/check-required-contexts-test.sh— 5/5 pass (unchanged by the edit; run to confirm nothing else moved).bash -n scripts/check-required-contexts.sh— parses.awesome-gleam×2,casket-ssg,coord-tui,vext), allintegration_id: 15368.