fix(gate): stop claiming tropical-types publishes the bare Hypatia name - #872
Conversation
The header said that repository "now publishes the bare name from an inline job and the prefixed name from its wrapper caller". Only the second half is true: its workflow set contains no job publishing `Hypatia Neurosymbolic Analysis`, and the live check-run list on `main` shows the prefixed name and the guard, nothing bare. The claim came from writing the header from memory of the fix's intent rather than from the repository, and it survived two review passes — including one that rewrote the surrounding tense — which is the same failure mode this whole gate exists to catch: an unverified statement about CI state, accepted because it reads plausibly. Truthful version: the caller is named `hypatia`, so the prefixed name is published, and nothing requires the bare one. The inline-implementation pattern belongs to `hyperpolymath/defiant` and is documented as such in the audit.
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (19)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe header comment in ChangesRequired context rationale
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the comment bright Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
🤖 Completed: Generate docstrings for PR #872 — View PR #875 |
|
…Tailscale setup (#875) Remove Codecov filenames and mentions as standalone coverage signals in the certifier, and recommend coverage generators. Correct the gate comment about tropical-types publishing a prefixed check name. Update integration bypass findings and document Tailscale workflow setup and required secrets. This range materially exceeds the docstring-generation task for PR #872: it includes certifier behavior changes and operational documentation, with no generated docstrings. Validation: commit history reports exact-string and bracket-balance checks for the Rust edit; cargo check was not run because the toolchain was unavailable. No additional validation was run. [View coding task](https://app.coderabbit.ai/code/tasks/b12979dd-741a-542e-9d3e-1a1f1a21598d?source=coding_agent_github_pr_description) Co-authored-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
1 participant
What
scripts/check-required-contexts.shonmainclaims, in its header, thathyperpolymath/tropical-types"now publishes the bare name from an inline job and the prefixed name from its wrapper caller".Only the second half is true.
Hypatia Neurosymbolic Analysis(verified by reading everyname:in.github/workflows/onmain);mainshows exactlyhypatia / Hypatia Neurosymbolic Analysis(wrapper),Required contexts are producible(guard) and the ordinary estate checks — nothing bare.The inline-implementation pattern is real, but it belongs to
hyperpolymath/defiant, and the audit documents it there under The correct way to satisfy a bare name.Why this gets a PR of its own
The sentence was written from the intent of the fix rather than from the repository, and it survived two passes — including one that rewrote the surrounding tense. That is the same failure this gate exists to catch: a plausible statement about CI state that nobody checked. A gate whose own header misdescribes a repository's published checks is not a gate anyone should trust.
Verification
bash -n scripts/check-required-contexts.sh— parses.bash scripts/tests/check-required-contexts-test.sh— 5/5 pass (the fixture is hermetic, so the header edit cannot affect it).GET /repos/hyperpolymath/tropical-types/commits/main/check-runsand against the workflow files atmain.