fix(audit,gate): withdraw the five residues — a file-based census cannot see GitHub-generated checks - #876
Merged
Conversation
…not see GitHub-generated checks The five contexts this census flagged as unsatisfiable are all published: every one reports in the check-run history of the repository that requires it, as a job of a GitHub-generated workflow (code scanning default setup and friends) that no file in the repository mentions. Evidence, gathered 2026-09-20 from check-runs on the default branch: awesome-gleam Analyze (actions) 8 of the last 8 commits, and PR #12's head awesome-gleam Adjust Configuration reports on main (intermittent) casket-ssg Analyze Code (actions) 15 of the last 30 commits coord-tui CodeQL Analysis (actions, none) 5 of the last 8 commits, and PR #63's head vext CodeQL Analysis (actions, none) 12 reports over 8 commits, and PR #51's head The previous commit stated that all five were re-checked and are "live defects". That re-check answered the wrong question: it confirmed the *rules* were live (active enforcement, ~DEFAULT_BRANCH, integration_id 15368) and never asked whether a *publisher* exists. The publisher is the platform. This matters beyond the ledger: merged guidance to go and patch four repositories' required-status-check lists would have deleted working gates on false evidence, and the deleted names would have been the ones nothing could see — the checks GitHub generates itself. Changes: * the audit's results now read 0 unsatisfiable, with the five candidates and their evidence; the residues table becomes the refuted-candidates table; * the method note becomes the operational rule: a file-based pass may only produce candidates; an unsatisfiable verdict becomes a finding only after check-run history confirms the name never reports; a required context is never deleted on a file-based verdict alone; * the gate carries the same limit in its header, in its warning and error text, and in --print-commands, so the person reading a finding is told to confirm it before acting; * the census caveats section cites this as the worked example rather than a hypothetical. The class remains real — tropical-types#17 was a genuine mis-named requirement. What changes is the confidence level a file-based census may claim.
Contributor
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Withdraws the five "unsatisfiable required contexts" this census reported, because all five are published.
Each one reports in the check-run history of the repository that requires it — as a job of a GitHub-generated workflow (code scanning default setup and friends) that no file in the repository mentions:
awesome-gleamAnalyze (actions)awesome-gleamAdjust Configurationmain(intermittent)casket-ssgAnalyze Code (actions)coord-tuiCodeQL Analysis (actions, none)vextCodeQL Analysis (actions, none)Why the previous pass got it wrong
The verification in the previous commit asked whether the rules were live — active enforcement,
~DEFAULT_BRANCH,integration_id: 15368. It never asked whether a publisher exists. For these five the publisher is the platform itself, not the repository, so a census over repository files cannot see it.That is not a footnote. Acting on the previous version would have meant patching four repositories' required-status-check lists to delete working gates, on false evidence, and the names deleted would have been the ones nothing in the repository can see.
What changes
unsatisfiableverdict becomes a finding only after check-run history confirms the name never reports; a required context is never deleted on a file-based verdict alone;--print-commands, next to the remediation it prints;Verification
bash scripts/tests/check-required-contexts-test.sh— 5/5 pass.bash scripts/check-canonical-names.sh origin/main— clean.GET /repos/{r}/commits/{default}/check-runsand the check-runs on a recent PR head.