fix(ci): repair the unbalanced jq filter in the Hypatia findings validator - #886
Merged
Merged
Conversation
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The findings validator's jq program does not compile:
The filter has 3 opening and 4 closing parentheses. When the check was rewritten from
length == 1 and (.[0] | type == "array" and all(...))(the form still present at 591cea1) totype == "array" and length > 0 and all(...), the(.[0] | ...)wrapper was dropped but its closing paren was not — so the program is a syntax error and every run pinned at/after that rewrite fails the step with::error::Hypatia did not produce a valid findings array(exit 2). The scan itself succeeds; only the validator is broken.Removing the stray paren was verified locally against a real findings file (defiant, 69 findings, 12 of them
warn):bogus) → rc=1, so the gate still gatesDownstream: defiant's required
hypatia / Hypatia Neurosymbolic Analysiscontext is red because of this, and any other caller pinned into this window is too.