Skip to content

fix(main-red-round3): map drift repair + WH004-path asana ack - #959

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/main-red-round3
Sep 22, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/main-red-round3

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Round 3. #954 merged as 9c256b6 (with its 3 known failures); this PR carries the two fixes that landed after the merge, rebased onto main+9c256b67 (+#948, +#952):

  1. Standards map integrity (www unmapped since chore(www): migrate root .well-known/ to www/.well-known/ #851, SECURITY.md unmapped since the fix(main-red): repair the post-#899 red main (code + baseline triage + regen) #947 squash, .well-known entry stale since chore(www): migrate root .well-known/ to www/.well-known/ #851): replace with www/ + SECURITY.md entries, entry_count 122 -> 123. All 5 assertions pass locally.
  2. Both Hypatia gates: the real scanner emits invalid_actions_lock TWICE (verified by building Hypatia locally and scanning this tree): workflow_audit (acked in round 2) and WH004 standalone (rule_module workflow_hardening, full path — acked here, 211 -> 212, same hypatia invalid_actions_lock: asana/push-signed-commits floats setup-python@v2 transitive #951 root cause).

Also verified by local full-fidelity scan (194 findings, token-enabled): the only unacknowledged findings are CI-invisible (git-state dirty-tree + code-scanning-alert echoes that need a live PAT — see #957 for the PAT-refresh tripwire). #948/#952 introduce zero new findings.

Local battery: debt run 0 breached, map rc=0, uses-lock clean, registry in sync, both ratchets OK, gate keeps nothing CI-visible.

- standards-map.toml: repair drift the map gate caught. #851 moved
  root .well-known/ to www/.well-known/ but the map still listed the
  root path (assertion 1) and never mapped www/ (assertion 2); the
  #947 squash added SECURITY.md, also unmapped. Replace the stale
  .well-known entry with www/ (migration wrapper note) + add
  SECURITY.md; entry_count 122 -> 123. All 5 assertions pass locally.
- .hypatia-baseline.json: 211 -> 212. The real scanner emits
  invalid_actions_lock TWICE (verified by running Hypatia locally):
  workflow_audit (file actions.lock, acked in the previous commit)
  and WH004 standalone (rule_module workflow_hardening, full path).
  Ack the second path; same root cause and exit criteria (#951).

Ratchet-exception: .hypatia-baseline.json — second ack for the same asana float-transitive, other emission path (#951).
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d03f816d-0bba-450a-85b8-8afc3e3d642c

📥 Commits

Reviewing files that changed from the base of the PR and between 9c256b6 and 0c261f1.

📒 Files selected for processing (2)
  • .hypatia-baseline.json
  • standards-map.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (14)
  • GitHub Check: Trust pipeline summary
  • GitHub Check: analyze-actions / analyze
  • GitHub Check: analyze-js / analyze
  • GitHub Check: ci / Detect mix.exs
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / gitleaks
  • GitHub Check: scorecard / Run Scorecard PR
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: Repo self-tests
  • GitHub Check: Registry + topology in sync
🔇 Additional comments (2)
standards-map.toml (1)

35-35: LGTM!

Also applies to: 1520-1530, 1532-1543

.hypatia-baseline.json (1)

1735-1743: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation

    • Updated standards mapping to reflect the migration of .well-known files to the website root.
    • Added the project’s security policy to the documented root-level entry points.
  • Maintenance

    • Recorded an additional workflow security audit finding involving a transitive action dependency, including its tracking and expiry details.
    • Updated the standards map entry count to reflect the latest documentation structure.

Walkthrough

The pull request updates the standards map for the .well-known migration and SECURITY.md. It also adds a workflow hardening baseline entry for the transitive floating actions/setup-python@v2 dependency.

Changes

Standards metadata

Layer / File(s) Summary
Repository standards map entries
.standards-map.toml
The map count increases to 123. The stale root .well-known entry is replaced with a www entry, and a root SECURITY.md entry is added.
Workflow hardening baseline
.hypatia-baseline.json
A high-severity baseline record documents the duplicate invalid_actions_lock finding, its expiry date, and tracking issue.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: joshuajewell

Merge Risk: ⚪ Minimal · up to 0c261

The change updates standards metadata for the .well-known migration, adds SECURITY.md coverage, and records the known workflow baseline. No production behavior is changed, so it is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly explains both changes: standards-map repair and acknowledgement of the second WH004 invalid_actions_lock finding. It also records the verification results.
Title check ✅ Passed The title clearly identifies the two main changes: map drift repair and the WH004-path Asana acknowledgement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the map at dawn
New paths appear where old ones shone
A lock records the workflow’s trail
Security notes now guard the rail
Hop by hop, the standards grow

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 38d211f into main Sep 22, 2026
48 checks passed
@hyperpolymath
hyperpolymath deleted the fix/main-red-round3 branch September 22, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant