docs(deed): correct the descriptor census in the mapping doc - #984
Merged
Merged
Conversation
The census this document recorded on 2026-09-22 was wrong, and the explanation it offered for disagreeing with standards#960 was a rationalisation of a control that was correctly firing. It read "23 distinct descriptors across 52 on-disk paths… 39 of those paths cite the deleted launcher-standard.a2ml", and explained the gap against #960's own figure of 21 by asserting that two set-level directories inflate the count. The sweep had been run from developer/ with no scope restriction, so it counted 9 paths under archive/ quarantine snapshots and 7 under tools/opt/cargo/git/checkouts/ — neither a live repository. 52 - 16 = 36. #960's 21 was right; this document's 23 was wrong. "An undercount by more than 5x" was also wrong: 10 -> 21 is roughly 2x. Re-measured scoped to hyper-repos and meta-repos: 36 paths, 21 distinct descriptors, 29 citing paths, 17 distinct descriptors citing, 18 distinct upstream repositories, 71 citing lines in six shapes — all # comments. Corrected in place and dated rather than silently overwritten, matching the two withdrawals already in this document. Gate and suite re-run with the edit in place: rc=0, 19 passed 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo
Contributor
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The corrected census in the previous commit was itself measured with a broken exclusion. A ripgrep -g '!.claude/worktrees/**' glob only matches at the SEARCH ROOT, so it excluded nothing where worktrees are nested inside repos. It fails silently: no error, no warning, and it reads as scoping while supplying none. The exclude must be -g '!**/.claude/worktrees/**'. Path counts move: 36 -> 31 on disk, 29 -> 26 citing, 71 -> 66 lines. The distinct counts do NOT move: 21 distinct descriptors, 17 distinct descriptors citing, 18 distinct upstream repositories. That is exactly what removing duplicates should do, and it is the invariant worth trusting — the distinct figures were sound throughout, and only the path figures were ever inflated. The document now states the glob trap and marks the path counts as dated while the distinct counts stand. Gate and suite re-run: rc=0, 19 passed 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects a number I wrote and merged in
edac0d6a(#983, standards#960 AC4) — and then corrects that correction, because the first re-measurement was made with a silently-broken filter.What was wrong on
main§7 of
1-formats/deed/mappings/launcher-standard-to-praxis-deed.adocrecorded:and explained the disagreement with
standards#960's own figure of 21 by asserting that two set-level directories (_DATABASE,_ESOTERIC_GROUP) inflate an app-name census.All three numbers were wrong, the multiplier was wrong, and the explanation was a rationalisation of a control that was correctly firing. #960's 21 was right; the 23 in this document was wrong.
Why
The sweep had been run from
developer/with no scope restriction, and its worktree exclusion did not work. Three populations were counted that are not live repositories:archive/quarantine snapshotstools/opt/cargo/git/checkouts/(burble×5,gossamer×2).claude/worktrees/copies52 − 21 = 31. And 10 → 21 is roughly 2×, not "more than 5×".
⚠ The trap worth carrying: a
-gexclude without**/fails silently-g '!.claude/worktrees/**'looks right, runs without error, and excludes nothing where worktrees are nested inside repos — a ripgrep glob only matches at the search root. It reads as scoping and supplies none, the same class of defect as a vacuous gate. The working form is-g '!**/.claude/worktrees/**', with a positive control asserted on the filter's own output.The corrected census
Scoped to
hyper-reposandmeta-repos, nested worktrees verified absent from the result:*.launcher.a2mlpaths on disklauncher-standard.a2ml#comments, in six shapesThe invariant that says which figures to trust: fixing the exclusion moved the path counts (36→31, 29→26, 71→66) and left 21 / 17 / 18 unchanged — exactly what removing duplicates should do. The distinct counts were sound throughout; only the path counts were ever inflated. The document now marks the path counts as dated and the distinct counts as standing.
Shape of the fix
Corrected in place and dated, not silently overwritten — the same shape as the two
⚠ WITHDRAWN 2026-09-22blocks already in this document.Verification
Gate and suite re-run after each commit, since the doc names the deleted filename and depends on the allowlist:
Docs-only, one file, two commits.
Refs standards#960, #983.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo