Skip to content

ci(secret-scan): rename caller job key secret-scan -> scan (D243) - #37

Merged
hyperpolymath merged 1 commit into
mainfrom
ci/secret-scan-floor-key
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
ci/secret-scan-floor-key

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Rename the secret-scanner caller job key secret-scan → scan in .github/workflows/secret-scanner.yml, so the check context becomes scan / gitleaks — the context the estate Secret-Scan-Floor ruleset (D243/D244) requires. One-line change; reusable pin, triggers and permissions unchanged. actionlint output is identical before and after.

Commit created via GraphQL createCommitOnBranch (GitHub-signed, signature valid: true).

🤖 Generated with Claude Code

https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK

Secret-Scan-Floor (D243/D244) requires the context `scan / gitleaks` estate-wide. The caller job key here was `secret-scan`, which emits `secret-scan / gitleaks` and can never satisfy the floor. Rename only; the reusable pin and permissions are unchanged.

actionlint output identical before and after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: be7dd7af-9d8d-407a-a722-d7c8f26af752

📥 Commits

Reviewing files that changed from the base of the PR and between d5063d8 and 698bb6d.

📒 Files selected for processing (1)
  • .github/workflows/secret-scanner.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (9)
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.github/workflows/secret-scanner.yml (1)

21-21: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated internal automation configuration. There are no changes to product features or behaviour available to end-users. This update does not affect how the product works or change any existing capabilities.

Walkthrough

The secret-scanner workflow job key changed from secret-scan to scan. Its reusable workflow, inherited secrets and permissions are unchanged.

Changes

Secret scanner workflow

Layer / File(s) Summary
Rename workflow job key
.github/workflows/secret-scanner.yml
The job key changed from secret-scan to scan. The reusable workflow, inherited secrets and permissions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: 🟡 Moderate · up to 698bb

The rename may not satisfy the required secret-scan check context. Confirm the D243/D244 requirement and the emitted check before merging; otherwise the required check could remain unsatisfied.

Architecture Summary

Architecture risk: 🔵 Low · up to 698bb

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/secret-scanner.yml: Renamed the job from secret-scan to scan; its reusable workflow, secrets and permissions remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states that the CI secret-scan caller job key changes from secret-scan to scan.
Description check ✅ Passed The description directly explains the job-key rename, the required check context, and the unchanged workflow settings. It is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the scanner's name,
One short key now joins the game.
The workflow stays as it was before,
Its secrets and permissions keep their score.
I hop away beneath the moon,
With one small change complete so soon.

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 1, 2026 12:16
@hyperpolymath
hyperpolymath merged commit b096f12 into main Oct 1, 2026
19 of 22 checks passed
@hyperpolymath
hyperpolymath deleted the ci/secret-scan-floor-key branch October 1, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant