Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #34

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 526842c8-1afc-4b9a-8bc3-a277dc43b866

📥 Commits

Reviewing files that changed from the base of the PR and between d7b4336 and d61709b.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: lint-workflows
  • GitHub Check: lint-workflows
🔇 Additional comments (2)
.github/workflows/governance.yml (1)

17-20: LGTM!

.github/workflows/hypatia-scan.yml (1)

20-23: LGTM!


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Corrected workflow permission configuration for governance and security scanning jobs.
    • Ensured the specified read and security-event permissions are applied at the appropriate job level.

Walkthrough

The workflow files now place the permissions blocks at job level. The permission values remain unchanged for both reusable workflow jobs.

Changes

Workflow permission scope

Layer / File(s) Summary
Correct job-level permissions
.github/workflows/governance.yml, .github/workflows/hypatia-scan.yml
The permissions blocks now apply at job scope. The declared permissions remain actions: read, contents: read, and security-events: write.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: metadatastician

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the pull request fixes invalid CI permissions indentation. It matches the main change.
Description check ✅ Passed The description accurately explains the invalid YAML issue, the indentation fix, the preserved permissions, and the validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow lane
Permissions stand in place again
Read actions, contents too
Security events pass through
YAML hops with tidy grace

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 349cd45 into main Sep 21, 2026
5 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant