Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #82

Merged
hyperpolymath merged 6 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 6 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 57fa20fe-f15e-4c55-ad47-07e8e587b383

📥 Commits

Reviewing files that changed from the base of the PR and between 303ad05 and db678c4.

📒 Files selected for processing (6)
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/mirror.yml
  • .github/workflows/rust-ci.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/secret-scanner.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (21)
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: analyze (actions, none)
  • GitHub Check: ABI ↔ FFI structural conformance
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: panic-attack assail
  • GitHub Check: Zig FFI builds + tests (Zig 0.14.0)
🔇 Additional comments (6)
.github/workflows/governance.yml (1)

17-20: LGTM!

.github/workflows/hypatia-scan.yml (1)

20-23: LGTM!

.github/workflows/mirror.yml (1)

16-19: LGTM!

.github/workflows/rust-ci.yml (1)

18-21: LGTM!

.github/workflows/scorecard.yml (1)

14-18: LGTM!

.github/workflows/secret-scanner.yml (1)

20-23: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated workflow configuration to declare required permissions at the appropriate job level.
    • Standardised permission handling across governance, security scanning, mirroring, Rust checks and scorecard workflows.
    • Corrected workflow formatting and structure without changing the permissions granted or the referenced automation.

Walkthrough

Six GitHub Actions workflows now place actions, contents, and security-events permissions at the job level. The permission values remain read, read, and write.

Changes

Workflow permission declarations

Layer / File(s) Summary
Correct job-level permission declarations
.github/workflows/governance.yml, .github/workflows/hypatia-scan.yml, .github/workflows/mirror.yml, .github/workflows/rust-ci.yml, .github/workflows/scorecard.yml, .github/workflows/secret-scanner.yml
The workflows now use correctly structured job-level permissions mappings. Each mapping grants actions: read, contents: read, and security-events: write.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the cause and intended fix, but it does not follow the repository template. It omits the required Changes section, RSR Quality Checklist, and explicit Testing and Screenshots … Update the description with the template sections. List the six affected workflow files, record the applicable RSR checklist items, state the YAML validation command and result, and add terminal output or mark Screenshots as not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI permission-block indentation fix and the resulting invalid YAML issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the cause and intended fix, but it does not follow the repository template. It omits the required Changes section, RSR Quality Checklist, and explicit Testing and Screenshots sections. It also does not identify all six affected workflow files.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow lines
Permissions sit in proper signs
Actions read and contents too
Security events write through
Six small paths now align bright
YAML hops into the right height

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 5bcee5b into main Sep 21, 2026
18 of 23 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant