Skip to content

docs: add Signed commits section to CONTRIBUTING - #64

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3ecd5995-a061-4d82-b841-ec5664e244e3

📥 Commits

Reviewing files that changed from the base of the PR and between b6f3d86 and 2f7b3f6.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (26)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Detect Project Configuration
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Validate DEED manifests
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: submit-nuget
🔇 Additional comments (1)
CONTRIBUTING.adoc (1)

112-127: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added contribution guidance requiring signed commits on the default branch. People and interactive agents must use a registered SSH signing key and verified committer email.
    • Documented that apps, bots and workflows must create signed commits through the API or approved action.
    • Contributors must squash-merge pull requests. Unsigned commits on a pull request branch block merging, and rebase merging is disabled.

Walkthrough

The contribution guide adds signed-commit requirements for default-branch commits and pull request branches. It also specifies signing methods for different contributors and requires squash merges.

Changes

Signed-commit policy

Layer / File(s) Summary
Signing and merge requirements
CONTRIBUTING.adoc
The guide requires signed commits, sets signing methods for people, interactive agents, apps, bots, and workflows, and describes branch checks and merge restrictions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2f7b3

The guide documents signing and squash-merge requirements consistent with the referenced policy. No concrete current failure is established, so the change is mergeable under normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 2f7b3

The change is limited to contribution guidance and introduces no executable permission or deployment changes. Actual enforcement of the documented signing and merge restrictions was not verified; no introduced security weakness was established.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The visible policy scope is contribution to this repository's default branch. The changed document contains no executable expansion of service, tenant, credential, or deployment authority.

Trust Boundaries and Controls

  • inferred — The signing paths concern signature provenance. A GitHub signature does not independently establish that an automation caller is authorized to write or merge. The document does not grant new permissions, and actual caller authorization and merge enforcement remain outside the verified evidence.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the documentation change, its signing policy, and the expected contributor workflow.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding signed-commit guidance to CONTRIBUTING.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit signs each commit with care,
Then checks each branch before the merge.
SSH keys make the signatures clear,
Squash brings commits safely near.
The rabbit hops; the rules stay there.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@hyperpolymath
hyperpolymath merged commit dd4e6c8 into main Oct 1, 2026
34 of 40 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant