Repository navigation
chore(vext): port the remaining vex-tools delta; drop unused hickory-resolver - #105
Merged
Merged
Conversation
…resolver vex-tools is being retired into this repo. Of the 111 commits it carried past the shared merge-base 78ab1ca, two pieces of work were not already here: - vext-core: remove `hickory-resolver = "0.26"`. No source file in vext/ uses it (vex-tools removed it in 6e68b37); the lock loses 66 packages (hickory and the 65 crates only it pulled in) and nothing else. - vext-email-gateway: add the library target (src/lib.rs re-exporting `types`), the aspect / e2e / property integration tests and the criterion bench from vex-tools 4e345d6, with the `[lib]`, `[[bin]]`, `[[bench]]` sections and the criterion dev-dependency they need. Adapted to this repo's newer dependencies: rand 0.10 has no `OsRng` / `RngCore`, so the tests (and the existing unit test in types.rs, which did not compile under `cargo test`) use `SysRng` + `TryRng::try_fill_bytes`. Two inherited aspect tests asserted nothing; they now parse DIDs through serde and assert rejection / round-trip (a valid DID planted in the invalid list makes the test fail). Verified: `cargo test` in vext-email-gateway (4+7+16+8+11 pass) and `cargo test --workspace` in vext (all pass). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013PzSt7Jwt4Fz3R4xYYJ5k8
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (9)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Add Carrot credits or activate Agent usage billing to use Autopilot |
Contributor
|
❌ Failed to create Coding Agent finishing-touch task. Please try again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ports the last work from the standalone repo
hyperpolymath/vex-tools(last commit8b2af3f) into vexometer. The owner asked for vex-tools to become part of vexometer and be retired; it will be deleted after this merges, and its full history is kept in the owner's offline archive.vex-tools and vexometer share merge-base
78ab1ca. Since then vex-tools has 111 commits and vexometer 179. Almost all of vex-tools' delta was template scaffolding that vexometer had already removed or converted, A2ML (retired), PMPL licence files, Deno files, or.mddocuments vexometer had already turned into.adoc. Two pieces of real work were missing here, and this PR brings in only those.📌 New pins
Head SHA: e25d3d9.
Lockfile records changed:
vext/Cargo.lock: removes 66 packages:hickory-resolver 0.26.1and the 65 crates only it pulled in. No other package versions change; every change is a removal.vext-email-gateway/Cargo.lock: adds 28 packages:criterion 0.5.1(dev-dependency, benches only) and 27 crates it pulls in. No existing package version changes; every change is an addition.No
uses:added, noactions.lockentry, no container digest.Changes
vext/vext-core/Cargo.toml: dropshickory-resolver = "0.26". No.rsfile undervext/uses it. vex-tools removed it in6e68b37; here it had survived a later version bump.vext-email-gateway: adds a library targetsrc/lib.rsthat re-exportstypes. It also adds three integration-test files from vex-tools4e345d6(tests/aspect_test.rs,tests/e2e_test.rs,tests/property_test.rsplus its proptest regressions) and the criterion benchbenches/gateway_bench.rs. The[lib],[[bin]]and[[bench]]sections and the criterion dev-dependency they need are added toCargo.toml.OsRngorRngCore, so key generation usesrand::rngs::SysRngwithTryRng::try_fill_bytes. That covers the ported tests and the existing unit test insrc/types.rs, which did not compile undercargo testonmain.aspect_invalid_did_formatnever used its list of invalid DIDs, andaspect_did_string_parsingdiscarded the string it was meant to parse. Both now deserialise the DID from its string and assert rejection or a round-trip. A valid DID planted in the invalid list makes the first test fail, so it does check something.The lazy-eliminator tests from the same vex-tools commit are already in vexometer, so they are not duplicated.
Not carried over, deliberately:
f7dd218;AI.djotandAI.a2ml(A2ML is retired);906eaa5ruling);deno.jsonandDeno.res(Deno is banned);docs/*.adoc,vext/PALIMPSEST.adocandTEST-NEEDS.md;scorecard.ymlthat would have added action pins.RSR Quality Checklist
Required
cargo test --no-fail-fastinvext-email-gatewaypasses 4 (lib), 7 (bin), 16 (aspect), 8 (e2e) and 11 (property) tests.cargo test --workspaceinvext/passes. Toolchain: cargo 1.97.1.rustfmt --checkclean. The existingsrc/main.rsandsrc/types.rswere already not rustfmt-clean onmain, and this PR does not reformat them.dead_codewarnings that remain come from the existingmain.rs, which declaresmod typesseparately from the library.unsafeblocks: none added.MPL-2.0on each new.rsfile, carried from vex-tools. The proptest regressions file is generated data with no header slot.As Applicable
.machine_readable/*.a2ml: not touched; A2ML is retired.TOPOLOGY.md: not applicable; no architecture change.criterion 0.5as a dev-dependency for the bench. One dependency is removed (hickory-resolver).Testing
cargo test --no-fail-fastinvext-email-gateway: all pass (counts above).cargo check --all-targetsinvext-email-gateway: builds, bench included.cargo test --workspace --no-fail-fastinvext: all pass.grep -c 'name = "hickory' vext/Cargo.lockgives 0.aspect_invalid_did_formatmakes the test fail; the original passes.main: the changes are exactly the removals and additions listed above.git diff --cached --check: clean. gitleaks and trufflehog: clean.Screenshots
Not applicable.
🤖 Generated with Claude Code
https://claude.ai/code/session_013PzSt7Jwt4Fz3R4xYYJ5k8