Repository navigation
fix(ci): pin third-party actions to full commit SHAs #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |||||||||||||||||
| timeout-minutes: 15 | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - name: Checkout | ||||||||||||||||||
| uses: actions/checkout@v7.0.1 | ||||||||||||||||||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||||||||||||||
| - name: Install system dependencies | ||||||||||||||||||
| run: | | ||||||||||||||||||
| sudo apt-get update | ||||||||||||||||||
|
|
@@ -28,13 +28,15 @@ jobs: | |||||||||||||||||
| timeout-minutes: 15 | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - name: Checkout | ||||||||||||||||||
| uses: actions/checkout@v7.0.1 | ||||||||||||||||||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||||||||||||||
| - name: Install Rust toolchain | ||||||||||||||||||
| # v1 tag, not a SHA: dtolnay force-moves toolchain branches, so no | ||||||||||||||||||
| # symbolic ref contains the old pin and lockfile generation refuses it. | ||||||||||||||||||
| # The actions.lock records the resolved SHA; the toolchain must be an | ||||||||||||||||||
| # explicit input because the ref no longer selects it. | ||||||||||||||||||
| uses: dtolnay/rust-toolchain@v1 | ||||||||||||||||||
| uses: dtolnay/rust-toolchain@02cb101ec7c40f2c49e1d9714d64511d8e1b74de # v1 | ||||||||||||||||||
| with: | ||||||||||||||||||
| toolchain: v1 | ||||||||||||||||||
| with: | ||||||||||||||||||
| toolchain: stable | ||||||||||||||||||
| - name: Install system dependencies | ||||||||||||||||||
|
Comment on lines
+38
to
42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: sed -n '1,60p' .github/workflows/quality-gates.ymlRepository: hyperpolymath/vexometer Length of output: 1691 🌐 Web query:
💡 Result: <search_synthesis> <source_evidence> Citations:
🌐 Web query:
💡 Result: <search_synthesis> <source_evidence> Citations:
Use one valid The step contains two Proposed fix uses: dtolnay/rust-toolchain@02cb101ec7c40f2c49e1d9714d64511d8e1b74de # v1
with:
- toolchain: v1
- with:
toolchain: stable📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.37.1)[error] 40-40: duplication of key "with" in mapping (key-duplicates) 🤖 Prompt for AI Agents |
||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: hyperpolymath/vexometer
Length of output: 13898
🤖 get_repo_knowledge executed:
get_repo_knowledge hyperpolymath/vexometer /tmp/coderabbit-repo-knowledge/hyperpolymath-vexometer-874a3fbc/conventionsLength of output: 7144
Synchronise workflow pins with
.github/workflows/actions.lock..github/workflows/actions.lockis machine-generated and is the declared pin authority forpush-email-notify.yml. The affected workflows use refs that differ from their lockfile entries. Regenerate the lockfile withgh actions-lock, or update the workflow pins to match the intended lock entries:pages.yml: checkoutv4.4.0, upload-pages-artifactv3.0.1, deploy-pagesv4.0.5.push-email-notify.yml:smtp-notify-action@v0.2.0, using the lockfile commit.quality-gates.yml: checkoutv4.3.1.workflow-linter.yml: checkoutv4.1.1.📍 Affects 4 files
.github/workflows/pages.yml#L23-L25(this comment).github/workflows/pages.yml#L42-L42.github/workflows/pages.yml#L55-L55.github/workflows/push-email-notify.yml#L43-L43.github/workflows/quality-gates.yml#L17-L17.github/workflows/quality-gates.yml#L31-L31.github/workflows/workflow-linter.yml#L17-L17🤖 Prompt for AI Agents