Skip to content

test(ci): security-events to job-level only in codeql.yml (residual startup_failure probe) - #92

Closed
hyperpolymath wants to merge 1 commit into
mainfrom
fix/codeql-perms-experiment
Closed

hyperpolymath wants to merge 1 commit into
mainfrom
fix/codeql-perms-experiment

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Diagnostic PR

vexometer remained startup_failure on CodeQL after #90's v4.38.1→v4.38.0 rollback — the only repo in the estate where the proven fix didn't cure it. Its codeql.yml is also the only one in the estate that grants security-events: write at workflow top level (all passing repos keep it job-level only). This PR tests whether that grant shape is the residual blocker.

  • Pass → merge (harmless hygiene either way) and the startup mystery is solved.
  • Still startup_failure → the residue is repo-side, not file-side; next check is Settings → Code security / Actions policy (needs owner console).

… startup_failure)

All estate repos whose codeql passes keep security-events: write at JOB
level only (hypatia, nexia-list, standards canonical). vexometer is the
sole remaining startup_failure after the v4.38.1 rollback (#90), and its
codeql.yml is the only one ALSO granting it at workflow top level. This
is a measurement PR: if the pin rollback alone was insufficient, the
top-level grant variant is now the only structural difference.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 64906acb-b777-482d-be31-262bd31a8260

📥 Commits

Reviewing files that changed from the base of the PR and between 8dc873a and ddab980.

📒 Files selected for processing (1)
  • .github/workflows/codeql.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/codeql.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (15)
  • GitHub Check: scan / gitleaks
  • GitHub Check: governance / Security policy checks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: lint-workflows
  • GitHub Check: lint-workflows

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated security scanning workflow permissions by limiting elevated access to the analysis job.
    • No changes to user-facing features or functionality.

Walkthrough

The CodeQL workflow removes the workflow-level security-events: write permission. The CodeQL analysis job retains the same permission locally.

Changes

CodeQL permissions

Layer / File(s) Summary
Scope CodeQL security permissions
.github/workflows/codeql.yml
The workflow-level security-events: write permission was removed. The CodeQL job-level permission remains.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to ddab9

The change narrows CodeQL permission scope while retaining access for the analysis job. No actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI permission change in codeql.yml and its diagnostic purpose.
Description check ✅ Passed The description directly explains the CodeQL startup failure investigation and the workflow-level permission change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath

Copy link
Copy Markdown
Owner Author

Result: negative. Top-level security-events: write removed here → CodeQL still startup_failure (run on this PR). Not the grant shape. Closing this diagnostic arm; see #93.

@hyperpolymath
hyperpolymath deleted the fix/codeql-perms-experiment branch September 22, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants