Skip to content

docs: add Signed commits section to CONTRIBUTING - #55

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e936d965-4ac3-4e32-85f9-a9f8bb40699b

📥 Commits

Reviewing files that changed from the base of the PR and between 52f221b and 0c25e4c.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (19)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: CodeQL Analysis (actions, none)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Groove manifest check
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
CONTRIBUTING.adoc (1)

22-37: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Documented the signed-commit requirements for changes reaching the default branch, including signing methods for people, agents, apps and workflows.
    • Clarified that pull requests must be squash-merged and that unsigned commits prevent merging.

Walkthrough

The contribution guide now defines signed-commit requirements for contributions and specifies how unsigned commits affect pull request merging.

Changes

Signed-commit policy

Layer / File(s) Summary
Commit signing and merge requirements
CONTRIBUTING.adoc
The guide specifies signing requirements for people, interactive agents, apps, bots and workflows. It requires squash merges, rejects unsigned commits, and states that affected branches must be recreated and submitted in a new pull request.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 0c25e

The signed-commit and squash-merge guidance is supported by the active ruleset and GitHub’s documented checks. The available evidence does not establish whether rebase merging is disabled, but no merge blocker is verified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 0c25e

The change documents signing and merge requirements without granting new privileges or changing executable controls. No introduced security weakness was established, but the claimed bypass restrictions and merge-method configuration remain unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The policy concerns contributor and automation commit paths into this repository’s default branch. The inspected change does not expand service, tenant, credential, or data-store authority.

Trust Boundaries and Controls

  • observed — People and interactive agents must use GitHub-registered SSH signing keys and verified committer email. Apps, bots, and workflows must use API-mediated commit creation instead of pushing local commits. These are distinct documented authenticity paths, not new grants of repository write permission.
  • observed — An earlier source inspection reported an active required-signatures ruleset targeting the default branch. Actual bypass permissions and enabled merge methods were not established, so the document’s stronger enforcement assertions remain only partially corroborated.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding a Signed commits section to CONTRIBUTING. It is concise and specific.
Description check ✅ Passed The description directly explains the documentation change, its signing policy requirements, and the affected contributor guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each commit’s seal,
Then signs each change with care and zeal.
The branch moves forward, signed and neat,
Squash-merged for a tidy feat.
With every rule in clear array,
The rabbit hops along its way.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@hyperpolymath
hyperpolymath merged commit a8fce59 into main Oct 1, 2026
26 of 28 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant