-
Notifications
You must be signed in to change notification settings - Fork 8
ENGTAI-64543: expose withGrpcConn to allow exporters to share connection #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 47.79% 47.70% -0.09%
==========================================
Files 62 62
Lines 3013 3050 +37
==========================================
+ Hits 1440 1455 +15
- Misses 1499 1518 +19
- Partials 74 77 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think creating connection explicitly will be better. This is good. |
|
@t-santoshsahu (default of 30s) goagent/instrumentation/opentelemetry/batchspanprocessor/batch_span_processor.modified.go Lines 264 to 302 in 0e09d2c
|
Description
Originally I tried implementing this by storing a single global exporter and then each new registered service tracer would have it's own in memory exporter. This performed essentially the same(marginal benefit ~1% in benchmarks..)
As an alternative, otel exposes a
WithGRPCConnargument we can pass to each exporter. This keeps our implementation simpler and achieves essentially the same result.Since we need to have a reference to the shared connection the flow would be:
In my benchmarks using the WithGrpcConn option with 10 services and sending 10k spans per service:
(I used the gopsutil pkg for network tests and was reporting to local collector, so I think that may be messing up network stats specificall)