Skip to content

publish: fix hash disagreement with app store #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nick1udwig merged 2 commits into from
Aug 26, 2025
Merged

publish: fix hash disagreement with app store #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06b33a
publish: use same function as app store to compute keccak256
nick1udwig Aug 26, 2025
2865796
publish: add newline if none is there
nick1udwig Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ semver = "1.0"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
sha2 = "0.10.8"
sha3 = "0.10.8"
syn = { version = "2.0", features = ["full", "visit", "parsing", "extra-traits"] }
thiserror = "1.0"
tokio = { version = "1.28", features = [
Expand Down
17 changes: 14 additions & 3 deletions src/publish/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,20 @@ pub fn make_remote_link(url: &str, text: &str) -> String {

#[instrument(level = "trace", skip_all)]
fn calculate_metadata_hash(package_dir: &Path) -> Result<String> {
let metadata_text = fs::read_to_string(package_dir.join("metadata.json"))?;
let hash = keccak256(metadata_text.as_bytes());
Ok(format!("0x{}", hex::encode(hash)))
let mut metadata_text = fs::read_to_string(package_dir.join("metadata.json"))?;
if !metadata_text.ends_with('\n') {
metadata_text.push('\n');
}
let hash = keccak_256_hash(metadata_text.as_bytes());
Ok(hash)
}

/// generate a Keccak-256 hash string (with 0x prefix) of the metadata bytes
pub fn keccak_256_hash(bytes: &[u8]) -> String {
use sha3::{Digest, Keccak256};
let mut hasher = Keccak256::new();
hasher.update(bytes);
format!("0x{:x}", hasher.finalize())
}

#[instrument(level = "trace", skip_all)]
Expand Down