J/template hyperapp by jurij-jukic · Pull Request #380 · hyperware-ai/kit

jurij-jukic · 2025-10-10T12:37:48Z

Insert hyperapp skeleton into kit templates.

I made a few changes to hyperapp skeleton which are not easily visible here (due to the whole repo being new, rather than just diffs), so here are the relevant ones to inspect:

kit/src/new/templates/rust/ui/hyperapp-skeleton/Cargo.toml

Lines 7 to 11 in 8556e3b

    
           members = [ 
        
               "skeleton-app", 
        
               "target/hyperapp-skeleton-caller-utils", 
        
               "target/hyperapp-skeleton-caller-util?", 
        
           ]

kit/src/new/templates/rust/ui/hyperapp-skeleton/skeleton-app/Cargo.toml

Lines 7 to 9 in 8556e3b

    
           [dependencies.hyperapp_skeleton_caller_utils] 
        
           optional = true 
        
           path = "../target/hyperapp-skeleton-caller-utils"

kit/src/new/templates/rust/ui/hyperapp-skeleton/skeleton-app/Cargo.toml

Lines 24 to 26 in 8556e3b

    
           [features] 
        
           caller-utils = ["hyperapp_skeleton_caller_utils"] 
        
           default = ["caller-utils"]

kit/src/new/templates/ui/hyperapp-skeleton/ui/src/utils/api.ts

Lines 8 to 18 in 8556e3b

    
           export async function makeApiCall<TRequest, TResponse>( 
        
             call: ApiCall<TRequest> 
        
           ): Promise<TResponse> { 
        
             const basePath = 
        
               BASE_URL || 
        
               (typeof window !== 'undefined' 
        
                 ? (() => { 
        
                     const [firstSegment] = window.location.pathname.split('/').filter(Boolean); 
        
                     return firstSegment ? `/${firstSegment}` : ''; 
        
                   })() 
        
                 : '');

kit/src/new/templates/ui/hyperapp-skeleton/ui/src/utils/api.ts

Lines 34 to 43 in 8556e3b

    
           const result = await response.json(); 
        
           if (result && typeof result === 'object') { 
        
             if ('Ok' in result) { 
        
               return (result as { Ok: TResponse }).Ok; 
        
             } 
        
             if ('Err' in result) { 
        
               throw new Error(`API returned an error: ${(result as { Err: unknown }).Err}`); 
        
             } 
        
           } 
        
           return result as TResponse;

There is a few more but these are the significant ones. It's basically the changes required to make hyperapp-skeleton run out of the box with kit bs --hyperapp as soon it's generated from the template.

kit new --template hyperapp-skeleton skel-template-new-dir --ui works now.

…late-hyperapp

nick1udwig · 2025-10-14T21:41:38Z

+[workspace]
+members = [
+    "skeleton-app",
+    "target/hyperapp-skeleton-caller-utils",


remove this; we want the wildcard below but not this one

the reason is for building from scratch: when building from scratch the wildcard version is happy but the non-wildcard version complains

Fresh builds work with or without that line for me. Remove the line or keep? Your choice.

Remove, just keep the wildcard

nick1udwig · 2025-10-14T21:47:58Z

+
+[features]
+caller-utils = ["hyperapp_skeleton_caller_utils"]
+default = ["caller-utils"]


I think we should remove this because it will interfere with fresh builds. We should test to confirm/falsify: does this mess up building fresh?

Again, doesn’t make a diff with fresh builds. Remove or keep, your choice.

Let's remove

nick1udwig · 2025-10-14T21:54:14Z

+use hyperprocess_macro::hyperprocess;
+
+// HYPERWARE PROCESS LIB IMPORTS
+// These are provided by the hyperprocess_macro, DO NOT add hyperware_process_lib to Cargo.toml


remove these two comments

jurij-jukic · 2025-10-15T13:59:25Z

update resources/example-apps/file-explorer to use the latest hyperdrive develop file-explorer https://github.com/hyperware-ai/hyperdrive/tree/ed2bd3ab287eb281ccbba7bf3c122a3d311fdad8/hyperdrive/packages/file-explorer

any reason not to make file-explorer, id and sign subtrees in kit?
Update: its easier to copy paste when an update happens than the overhead of having a subtree. Not gonna build this.

jurij-jukic · 2025-10-21T10:01:01Z

In the last commit, removed api.ts, and wired up caller-utils.ts correctly.

jurij-jukic · 2025-10-21T10:02:58Z

Re previous change request to remove vite-env.d.ts. Keeping that because it's useful in Vite projects.

jurij-jukic · 2025-10-21T11:59:02Z

New file explorer wired up. Last detail - keeping the api folder in that one (since its an example, and we dont expect people to build it), or removing it?

nick1udwig

Almost there, a few more comments

nick1udwig · 2025-10-21T22:44:51Z

+  // UI state
+  isLoading: boolean;
+  error: string | null;
+}


I think this file should be removed

I removed the api related types (as thats LLM bad habit), but kept the interface SkeletonStore type as types/skeleton.ts is a clean place for LLMs to update types to match the rust backend

nick1udwig · 2025-10-21T22:55:08Z

@@ -0,0 +1,2 @@
+// Re-export everything from caller-utils
+export * from '../../../target/ui/caller-utils';


Future TODO: remove these ui/src/types/api.ts files and update imports to point to the caller-utils file themselves. This api.ts is a bad pattern that LLMs are already prone to, so we shouldn't demo it for them even more

nick1udwig · 2025-10-21T22:55:33Z

@@ -0,0 +1,2 @@
+// Re-export everything from the generated caller-utils
+export * from '../types/api';


ditto on "future TODO": eventually remove this

nick1udwig · 2025-10-21T23:55:13Z

+
+### 5. Rename as appropriate
+
+Change names throughout from `skeleton-app` (and variants) as appropriate if user describes app name.


the name should match the template name (i.e. both should be hyperapp-skeleton) throughout so that kit will appropriately rename stuff throughout (i.e. when you do kit new foo --template hyperapp-skeleton --ui it will rename the package and process to foo -- but only if the names throughout properly match the template name)

Ok, so I renamed it here to hyperapp-skeleton, but imo this deserves its own PR to make sure kit renames things properly (and should be done by kit rather than llms to be deterministic). Just at first glance, e.g. metadata.json doesn't get changed at all, and there are likely other places which require renaming. So, punt for other PR?

Ok, we can push back to another PR, but if so we are agreeing we will not make a new kit release until we have it in

nick1udwig · 2025-10-21T23:58:44Z

New file explorer wired up. Last detail - keeping the api folder in that one (since its an example, and we dont expect people to build it), or removing it?

I'm fine keeping it, but we should add a note in README or something to that effect

This reverts commit 65597a2.

nick1udwig

lgtm, nice work! let's merge and make some follow-up issues so we don't lose track of the TODOs here in the comments

jurij-jukic and others added 4 commits October 10, 2025 14:28

add hyperapp skeleton to templates

5f02314

Format Rust code using rustfmt

bfc0a22

template

8babfa7

Merge remote-tracking branch 'origin/j/template-hyperapp' into j/temp…

8556e3b

…late-hyperapp

jurij-jukic changed the base branch from master to develop October 10, 2025 12:38

add resources

77c513f

jurij-jukic requested a review from nick1udwig October 10, 2025 13:04

rename hyperapp-skeleton to hyperapp

01129a8

nick1udwig requested changes Oct 14, 2025

View reviewed changes

remove pkg/ui and add to gitignore

e684a9f

jurij-jukic added 6 commits October 15, 2025 16:05

remove garbage from example-apps/id/id

b8fdf40

rename back from hyperapp to hyperapp-skeleton

6292efb

remove machine generated api folder

097c3d4

fix icon

c8ed6bb

remove obsolete comments.

08af650

remove api.ts and wire backend calls correctly

1a61992

jurij-jukic added 6 commits October 21, 2025 12:55

wit_world fix

fdc9304

remove useless request_body args

afcbb0f

remove file explorer

61d5dd7

update file explorer

a969490

gitignore cleanup

03ca3c7

remove pkg/ui from file explorer

01289dc

nick1udwig requested changes Oct 21, 2025

View reviewed changes

jurij-jukic added 2 commits October 22, 2025 11:31

clean up cargo tomls in hyperapp skeleton

6206ce7

remove types/skeleton.ts

65597a2

jurij-jukic added 6 commits October 22, 2025 11:44

remove CHANGES_MADE.md

3a0ba89

remove expand-sign-old.txt

f10ac75

remove caller utils from file explorer example

9b15386

Revert "remove types/skeleton.ts"

f459a67

This reverts commit 65597a2.

remove api stuff from types/skeleton.ts and some readme updates

5bc7535

update readme re file explorer api

12bb808

nick1udwig approved these changes Oct 22, 2025

View reviewed changes

jurij-jukic merged commit ca8f4cc into develop Oct 22, 2025
1 check passed

jurij-jukic deleted the j/template-hyperapp branch October 22, 2025 13:02

	members = [
	"skeleton-app",
	"target/hyperapp-skeleton-caller-utils",
	"target/hyperapp-skeleton-caller-util?",
	]

	[dependencies.hyperapp_skeleton_caller_utils]
	optional = true
	path = "../target/hyperapp-skeleton-caller-utils"

	[features]
	caller-utils = ["hyperapp_skeleton_caller_utils"]
	default = ["caller-utils"]

	export async function makeApiCall<TRequest, TResponse>(
	call: ApiCall<TRequest>
	): Promise<TResponse> {
	const basePath =
	BASE_URL \|\|
	(typeof window !== 'undefined'
	? (() => {
	const [firstSegment] = window.location.pathname.split('/').filter(Boolean);
	return firstSegment ? `/${firstSegment}` : '';
	})()
	: '');

	const result = await response.json();
	if (result && typeof result === 'object') {
	if ('Ok' in result) {
	return (result as { Ok: TResponse }).Ok;
	}
	if ('Err' in result) {
	throw new Error(`API returned an error: ${(result as { Err: unknown }).Err}`);
	}
	}
	return result as TResponse;

		@@ -0,0 +1,2 @@
		// Re-export everything from caller-utils
		export * from '../../../target/ui/caller-utils'; No newline at end of file

		@@ -0,0 +1,2 @@
		// Re-export everything from the generated caller-utils
		export * from '../types/api'; No newline at end of file


		### 5. Rename as appropriate

		Change names throughout from `skeleton-app` (and variants) as appropriate if user describes app name.

Conversation

jurij-jukic commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jurij-jukic commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jurij-jukic commented Oct 21, 2025

Uh oh!

jurij-jukic commented Oct 21, 2025

Uh oh!

jurij-jukic commented Oct 21, 2025

Uh oh!

nick1udwig left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jurij-jukic Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nick1udwig commented Oct 21, 2025

Uh oh!

nick1udwig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jurij-jukic commented Oct 10, 2025 •

edited

Loading

jurij-jukic commented Oct 15, 2025 •

edited

Loading

jurij-jukic Oct 22, 2025 •

edited

Loading