feat: opt-in Continue on Green (0x3FD mux0 bit39) - #145
Merged
Conversation
bit39 = UI_fsdContinueOnGreenWithCIPV from the ev-open-can-tools TSLLC plugin: continue through a green light behind a lead car without stalk confirmation. New continue_on_green toggle, independent of the existing bit38/TLSSC toggle (documented to pair with it), default OFF. - fsd_state.h: continue_on_green field - fsd_handler.c / .cpp: set bit39 on 0x3FD mux0 when enabled + fsd_enabled (before the HW3/HW4 split, so it applies to both) - can_signals.h: SIG_AP_CONTINUE_ON_GREEN_BIT - prefs.cpp: NVS key "cog" load/save - web_dashboard.cpp: Continue on Green toggle in Controls - test_fsd_core.c: test_continue_on_green (HW3 + HW4, on/off)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in Continue on Green toggle (default OFF) that sets bit 39 (
UI_fsdContinueOnGreenWithCIPV) on0x3FD(DAS_autopilotControl) mux 0 — continue through a green light behind a lead car without needing stalk confirmation. Refs #111.Source: ev-open-can-tools
enable-TSLLC-and-continue-on-green-with-car-infront.json. The project already has bit 38 (TLSSC /UI_fsdStopsControlEnabled) as theassist_tlssc_bit38toggle; this adds bit 39 as its own independent toggle. Bit 39 is meaningful alongside TLSSC (you stop at the light, then continue on green), so the dashboard notes "pairs with TLSSC", but the two toggles stay independent — this feature never auto-sets bit 38.Changes
fsd_state.h: newbool continue_on_green(default OFF).0x3FDhandlers: set bit 39 on mux 0 when the flag and FSD-selected are both on, applied before the HW split so HW3 and HW4 behave identically.can_signals.h:SIG_AP_CONTINUE_ON_GREEN_BIT 39.prefs.cpp: NVS persistence (cog).web_dashboard.cpp: "Continue on Green" toggle in Controls.test_fsd_core.c:test_continue_on_green(HW3/HW4 × on/off). 475 host tests pass.Notes
mainonce that merges.