fix: respect console log line limit - #40
Open
Hushlor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
read_logsexposed alinesparameter, but thesource: "console"branch dropped it whenreadLogscalledgetConsoleLogs. The console retrieval script therefore appliedsinceandfilter, then formatted every matching entry without enforcing a line limit.In the real test app, five uniquely tagged console messages queried with
lines: 2returned all five instead of the newest two. Android, iOS, and system-log paths use separate retrieval logic and were not affected.Summary
read_logs.linesthrough the complete console-log retrieval chainsinceandfilterbefore retaining the newest matching entries in chronological orderRegression coverage
lines: 2before the fixValidation
npm run build(using Git Bash as npm's script shell on Windows)npm run test:unit --workspace=@hypothesi/tauri-mcp-server— 64 passednpm run test:e2e --workspace=@hypothesi/tauri-mcp-server— 157 passed, 1 skippednpm run standardsThe console and Rust IPC buffer sizes remain intentionally out of scope.