Conversation
supun-io
requested changes
Aug 25, 2025
Member
There was a problem hiding this comment.
- Use for Add Publication
- Remove "Name" input. We will use the name given in the feed
- We need to fetch the feed within the HTTP request of creating a publication and show better error messages. Also, we don't want to add the publication if the RSS feed URL is wrong. (needs discussing)
# Conflicts: # backend/composer.json # backend/composer.lock # backend/src/Api/App/Controller/PublicationController.php # backend/src/Repository/CollectionUserRepository.php # backend/src/Service/Parser/RssParser.php # frontend/src/routes/app/(reader)/+layout.svelte
supun-io
requested changes
Sep 5, 2025
Member
There was a problem hiding this comment.
- Use a Button for + Add Publication (from HDS)
- When the "Add Publication" modal is opened, automatically focus the input
- While the publication is being added, show a loader (Use Modal Loader)
- In the PublicationController::addPublication, the idea of using an inspection is great! I suggest sending this $inspection into PublicationService->createPublication and do everything there (you won't need udpates like $publication->setConditionalGetEtag when you set it when creating the publication).
- Error handling in the UI (ex: when the feed fails)
- Create an ExceptionListener (see Relay). Most parts are handled by the internal lib, which converts the error to a JSON response with the correct response
- Show the error message in the modal when the API fails.
# Conflicts: # backend/composer.json # backend/composer.lock # backend/src/Api/App/Controller/CollectionController.php # backend/src/Api/App/Controller/PublicationController.php # backend/src/Repository/CollectionUserRepository.php
Creating a collection
Nadil-K
requested changes
Sep 25, 2025
|
|
||
| return $this->json([ | ||
| 'publication' => new PublicationObject($publication), | ||
| 'created' => $created, |
Member
There was a problem hiding this comment.
- Why do we need these created and attached booleans? Within the current codebase, I don't see any instance of it being used. Shall we remove it @supun-io?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.