[WIP] Use the full 64 bits of the cellID for surface lookup#78
Open
tmadlener wants to merge 1 commit intoiLCSoft:masterfrom
Open
[WIP] Use the full 64 bits of the cellID for surface lookup#78tmadlener wants to merge 1 commit intoiLCSoft:masterfrom
tmadlener wants to merge 1 commit intoiLCSoft:masterfrom
Conversation
Switching to e.g. system:8 bits can lead to cases where CellID0 truncates bits off of the cellID, making the lookup fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to e.g. system:8 bits can lead to cases where CellID0 truncates bits off of the cellID, making the lookup fail.
BEGINRELEASENOTES
DDPlanarDigiProcessorENDRELEASENOTES
Triggered by the discussion / conclusion in key4hep/k4geo#568 (comment). Without this a simple change to
system:8(from e.g.system:5will make the surface lookup fail asCellID0truncates to only 32 bits)I have tested this with CLD_02_v08 replacing
system:5withsystem:8and using the--trackingOnlyoption forCLDReconstruction.pyand tracking runs in both cases. However, efficiency seems to be down by a factor 2 forsystem:8at the moment