Fix crash if unable to calculate theta from the triplet#79
Merged
tmadlener merged 5 commits intoiLCSoft:masterfrom Mar 27, 2026
Merged
Fix crash if unable to calculate theta from the triplet#79tmadlener merged 5 commits intoiLCSoft:masterfrom
tmadlener merged 5 commits intoiLCSoft:masterfrom
Conversation
tmadlener
reviewed
Mar 24, 2026
Contributor
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
Mainly for posterioriti; looks like the partial fix for theta was done in #27
Similar question here as for iLCSoft/MarlinReco#158
Member
Author
|
I have added the warning logging. I think the code should never really reach here after adding the check for |
tmadlener
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
For github: Fixes iLCSoft/MarlinReco#157