Merged
Conversation
Preserve explicit zero-valued retry settings and clear transaction timers on rollback while hardening auto-organize and chat IPC against missing or late responses.
Resolve the PR conflicts by combining main's newer chat IPC and atomic-file-operation changes with the validated stable-branch guards and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on backporting essential stability and hardening guards to core backend services and IPC handlers. The changes prevent potential memory leaks, address edge cases with late or missing responses, and ensure configuration settings are strictly respected.
Core services and IPC hardening:
chatIpcservice by introducing a cleanup state to safely ignore late stream responses and prevent memory leaks.ParallelEmbeddingServiceto correctly preserve explicit zero-valued retry configurations by implementing nullish coalescing.AtomicFileOperationsto ensure transaction timeout timers are properly cleared upon transaction failure or rollback.fileProcessorto safely handle missing suggestion payloads by utilizing optional chaining.Testing and edge case coverage:
chatIpc.test.jsto verify that late query failures are ignored after cleanup and that malformed bridge responses are handled gracefully.fileProcessorto ensure files are correctly routed to the default folder when suggestion payloads are missing.ParallelEmbeddingServiceto explicitly verify that zero-retry options are accurately preserved.