fix(channel/lark): use code 0 for ACK payload to match Lark API convention - #816
Open
kerwan-zeng wants to merge 1 commit into
Open
fix(channel/lark): use code 0 for ACK payload to match Lark API convention#816kerwan-zeng wants to merge 1 commit into
kerwan-zeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lark APIs use code 0 for success (every API response in the codebase checks
code != 0for errors), but the WebSocket ACK frame was sending{"code":200}.Lark interpreted 200 as a non-zero failure code, causing every event to be marked FAIL with a ~3.7s timeout even though messages were processed successfully.